ci: add build-check workflow for multi-component CI pipeline#61
Conversation
fslongjin
commented
Apr 23, 2026
- Add GitHub Actions workflow to build and verify CubeMaster, Cubelet, agent, network-agent and CubeShim components
- Implement builder image caching with automatic rebuild on Dockerfile changes
- Use matrix strategy for parallel component builds with binary verification
- Configure path-based triggers for relevant source directories
|
Claude finished @fslongjin's task in 3m 57s —— View job PR Review: ci: add build-check workflow
DCO CheckThe commit SummaryOverall, this is a well-structured CI workflow. The matrix strategy for parallel builds, builder image caching with fallback logic, and binary verification are all good patterns. Below are the issues found, ranked by severity: Must Fix:
Should Fix: Suggestions: |
| expected_bins: | | ||
| _output/bin/network-agent | ||
|
|
||
| steps: |
There was a problem hiding this comment.
No dependency caching across matrix jobs. Each matrix job independently downloads Go modules and Cargo dependencies. Consider adding caching steps (e.g., actions/cache for ~/go/pkg/mod and ~/.cargo/registry) to speed up builds, especially since 5 parallel jobs all download similar dependencies.
Note: Since builder-run runs inside Docker with mounted volumes, the cache mount paths need to align with BUILDER_HOME inside the container. This may require some coordination with the Makefile.
- Add GitHub Actions workflow to build and verify CubeMaster, Cubelet, agent, network-agent and CubeShim components - Implement builder image caching with automatic rebuild on Dockerfile changes - Use matrix strategy for parallel component builds with binary verification - Configure path-based triggers for relevant source directories Signed-off-by: jinlong <jinlong@tencent.com>
2a4fc71 to
d6817c2
Compare
- Add CubeAPI to the build-check workflow for CI pipeline - Configure path-based triggers for CubeAPI changes - Implement build command and expected binaries for CubeAPI component Signed-off-by: jinlong <jinlong@tencent.com>