Correctly order metadata and cache free operations #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cljohnso
requested changes
Jan 21, 2025
Contributor
cljohnso
left a comment
cljohnso
left a comment
There was a problem hiding this comment.
Looks good with a few excess items.
| @@ -0,0 +1,113 @@ | |||
| /* | |||
| * Copyright 2025 Terracotta, Inc., a Software AG company. | |||
Contributor
There was a problem hiding this comment.
SAG reference for a new file?
| import com.terracottatech.frs.RestartStore; | ||
| import com.terracottatech.frs.RestartStoreException; | ||
| import com.terracottatech.frs.RestartStoreFactory; | ||
| import com.terracottatech.frs.config.FrsProperty; |
Contributor
There was a problem hiding this comment.
There are a few dead imports ...
|
|
||
| } | ||
|
|
||
| protected static void destroyMap(Map<?, ?> map) { |
Contributor
There was a problem hiding this comment.
Did you mean to call this?
chrisdennis
force-pushed
the
partial-cache-consistency
branch
from
da79ef0 to
5609c18
Compare
…cache-consistency
…cache-consistency
…cache-consistency
chrisdennis
force-pushed
the
partial-cache-consistency
branch
from
5609c18 to
448765a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.