client versions in cluster state dumps. #540
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2019
anthonydahanne
approved these changes
Jun 26, 2019
Member
anthonydahanne
left a comment
anthonydahanne
left a comment
There was a problem hiding this comment.
PR is approved but can't be merged because it's waiting for tc core and apis PRs to be merged - feel free to add the trace log or not
| if (topologyService.isCurrentServerActive()) { | ||
| dump.addState("cluster", topologyService.getClusterCopy().toMap()); | ||
| } else { | ||
| dump.addState("status", "This is a passive server, so it is unaware of connected clients and other stripe members."); |
Member
There was a problem hiding this comment.
not version related, but nice to have, thank you
| client.setVersion(versionObj.toString()); | ||
| } | ||
| } catch (NoSuchFieldException | IllegalAccessException e) { | ||
| // |
Member
There was a problem hiding this comment.
could be a trace log with "Client " + clientName + " does not have a version field set, probably because it's older
Contributor
|
Is there a reason this was never merged? |
Author
|
@myronkscott wanted to do it a different way. I don't know if he ever did it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terracotta-OSS/terracotta-apis#312
Terracotta-OSS/terracotta-core#1044