Issue when trying to update a GeoJsonCatalogItem

[Sivloc]

Hello !
I'm currently trying to implement a new Model extending the GeoJsonCatalogItem Model.
My use case is that i have $\approx$ 2000 polygons (always the same geometries) but with fluctuating attributes values.

I wanted to make it so when the layer is first added it's loading the geometry, and when the timeframe is playing, the values of the polygons' attributes are updated. (First request is GeoJSON, subsequent ones are CSV)
So far i'm pretty close, the request are handled correctly, but my layer is not updating.

I'm using this :

export default class DynamicGeoJsonCatalogItem extends GeoJsonCatalogItem {
  private clockDisposer?: () => void;
  private lastFetchedDate?: string; // ISO date like "2025-05-22"
 
  constructor(id: string, terria: Terria) {
    super(id, terria);
 
    // Attach clock tick listener after data is loaded
    if (!this.clockDisposer) {
      this.clockDisposer = this.terria.timelineClock.onTick.addEventListener(clock => {
        const currentIso  = JulianDate.toDate(clock.currentTime).toISOString();
        const currentDate = currentIso.slice(0, 10); // 'YYYY-MM-DD'
 
        if (currentDate !== this.lastFetchedDate) {
          this.lastFetchedDate = currentDate;
          this.updateFromTime(currentIso);
        }
      });
    }
  }

async updateFromTime(currentTime: string) {
    try {
      const timeKey = currentTime.slice(0, 10); // e.g. '2025-05-22'
      const csvUrl = this.baseCsvUrl + `${timeKey}`;
 
      const csvData = await loadCsv(csvUrl);
 
      runInAction(() => {
        this.applyCsvDataToGeoJson(csvData);
      });
    } catch (e) {
      console.error("Error loading or parsing CSV:", e);
    }
  }
 
  applyCsvDataToGeoJson(csvRows: any[]) {
    if (!this.geoJsonData || !this.geoJsonData.features) return;
 
    for (const feature of this.geoJsonData.features) {
      const lakeId = feature.properties.id;
      const row = csvRows.find((r: any) => r.id === lakeId);
      if (row) {
        feature.properties.level = row.level;
      }
    }
 
    // Force refresh of features
    this.setTrait(CommonStrata.user, "geoJsonData", this.geoJsonData);
  }

Not sure if
this.setTrait(CommonStrata.user, "geoJsonData", this.geoJsonData);

is the right method to use, or if my data formatting is wrong (i think it's the former)

just in case, here is what my data looks like

{"type" : "FeatureCollection", "features" : [{"type": "Feature", "geometry": {"type":"Polygon","coordinates": []}, "properties": {"id": 4460, "datetime": "2023-01-01T00:00:00+00:00", "etc": [] }}]}

and

[{"id":1,"datetime":"2020-02-26T00:00:00+00:00","etc": []}, 
 {"id":3,"datetime":"2020-02-26T00:00:00+00:00","etc": []}, 

[Sivloc]

I have some updates, my code is now working.
I still have some optimization work to do in this file.
I was still wondering if there was a more efficient way to refresh the values of some polygons. (I am using test.setTrait( CommonStrata.user, "url", "http://localhost:8080/postgrest-geojson/..." ); when creating the layer, which is a geojson, while the subsequent requests are csv data.

Thanks for any advice !

import GeoJsonCatalogItem from "terriajs/lib/Models/Catalog/CatalogItems/GeoJsonCatalogItem";
import Terria from "terriajs/lib/Models/Terria";
import CommonStrata from "terriajs/lib/Models/Definition/CommonStrata";
import { runInAction } from "mobx";
import loadCsv from "terriajs/lib/Core/loadCsv";
import JulianDate from "terriajs-cesium/Source/Core/JulianDate";
 
 
export default class DynamicGeoJsonCatalogItem extends GeoJsonCatalogItem {
  private clockDisposer?: () => void;
  private lastFetchedDate?: string; // ISO date like "2025-05-22"
  private _tomorrowData?: any;

  constructor(id: string, terria: Terria) {
    super(id, terria);

    // Attach clock tick listener after data is loaded
    if (!this.clockDisposer) {
      this.clockDisposer = this.terria.timelineClock.onTick.addEventListener(clock => {

        const currentIso = JulianDate.toDate(clock.currentTime).toISOString();
        const currentDate = currentIso.slice(0, 10); // 'YYYY-MM-DD'
        const tomorrow = new Date(JulianDate.toDate(clock.currentTime));
        tomorrow.setDate(tomorrow.getDate() + 1);
        const tomorrowIso = tomorrow.toISOString();
        
        if (currentDate !== this.lastFetchedDate) {
          this.lastFetchedDate = currentDate;
          this.updateFromTime(currentIso,tomorrowIso);
        }
      });
    }
  }
 
 
  dispose() {
    // Clean up the clock listener
    if (this.clockDisposer) {
      this.clockDisposer();
      this.clockDisposer = undefined;
    }
    super.dispose();
  }
 
  async updateFromTime(currentTime: string,tomorrowTime: string) {
    try {
      const timeKey = currentTime.slice(0, 10); // e.g. '2025-05-22'
      const tomorrowKey = tomorrowTime.slice(0, 10); // e.g. '2025-05-23'

      let csvData;
      if (!this._tomorrowData) {
        // First time: fetch both today and tomorrow, cache tomorrow
        const csvUrl = this.baseCsvUrl + `${timeKey}`;
        const tomorrowCsvUrl = this.baseCsvUrl + `${tomorrowKey}`;
        csvData = await loadCsv(csvUrl);
        this._tomorrowData = await loadCsv(tomorrowCsvUrl);
      } else {
        // On subsequent calls: use cached tomorrow as today, fetch new tomorrow
        csvData = this._tomorrowData;
        const tomorrowCsvUrl = this.baseCsvUrl + `${tomorrowKey}`;
        this._tomorrowData = await loadCsv(tomorrowCsvUrl);
      }

      // Mapping the csv with the header
      const [headers, ...dataRows] = csvData;
      const csvObjects = dataRows.map((row) =>
        Object.fromEntries(row.map((val,i) => [headers[i], val]))
      );
      
      runInAction(() => {
        this.applyCsvDataToGeoJson(csvObjects);
      });
    } catch (e) {
      console.error("Error loading or parsing CSV:", e);
    }
  }
 
  async applyCsvDataToGeoJson(csvRows: any[]) {

    if (!this._readyData || !this._readyData.features) return;

    let _newData = this._readyData
    for (const feature of _newData.features) {
      const lakeId = feature.properties.id;
      const row = csvRows.find((r: any) => Number(r.id) === Number(lakeId)); // CSV is string only
      if (row) {
        for (const key of Object.keys(row)) {
            feature.properties[key] = row[key];
        }
        feature.properties.level = row.level; // No need to convert here, Terria will handle it
      }
    }
 
    try {
      this.setTrait(CommonStrata.user, "geoJsonData", _newData);
      await this.loadMapItems();    // Force refresh of features
    } catch (e) {
      console.error("Error updating geoJsonData trait:", e);
    }
  }
 
  get baseCsvUrl(): string {
    return "http://localhost:8080/.../";  // <-- CSV Data
  }
}