update getRoot function to handle port properly#4
Open
JoshMcCullough wants to merge 1 commit intodevelopfrom
Open
update getRoot function to handle port properly#4JoshMcCullough wants to merge 1 commit intodevelopfrom
JoshMcCullough wants to merge 1 commit intodevelopfrom
Conversation
JoshMcCullough
force-pushed
the
jsm/update-express-port-handling
branch
from
bec30b2 to
0442381
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local port is being included in some URLs returned from Mage (e.g.
https://mage.somehost.net:8830/...), this appears to be happening becausereq.get('host')includes the port. I've updated theexpressconfig to enable thetrust proxyoption as well as get the "hostname" directly.This fixed the URL which is generated server side for observation attachments and export downloads
Docs: