Open
Conversation
Author
|
Hi, any thoughts on this? |
Member
|
I need to look a bit deeper. I suspect this will fail for code that actually throws a 0, or an empty string as an exception. Instead I think a fix will requite use of this pattern: 0, empty string, and undef are all valid as exceptions, so ultimately throws_ok will need to see if the eval passes or fails. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've written code to try to fix the case where you call throws_ok, the code doesn't die, and the test passes (RT#81529).
The test in t/Exception.t that doesn't throw ("throws_ok: normal exit matched") is failing due to this code change.
Just thought you'd like to consider this new behaviour, since the original (passing the test) is very confusing.