Started alternate API for dictionaries #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Properties get rid of the redundant () on each extension method. So, the choices of API so far are:
|
Member
|
I prefer property. I'm comfortable with the ones that come with dossier being "special" since when you create ones for your own domain it makes sense you'd put them directly against Any. |
Member
|
I'm happy with this PR. |
Member
|
@mwhelan I'm merging this so it can be released, but can you do another PR to talk about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @robdmoore . I have converted half the API to have the category in between. I think it will work quite well but have not done the whole API until I've guaged feedback to see if it's the right direction to follow.