MockFile.Create(string path, int bufferSize, FileOptions options, FileSecurity security) not implemented

[rkoeninger]

The overload of MockFile.Create that takes FileSecurity remains unimplemented as seen here.

[fgreinacher]

Hm, what should this do? Just set FileSecurity on the MockFile? I don’t think we want to really implement any kind of security mechanisms.

[rkoeninger]

Yeah, I think that's all it needs to do. Do whatever MockFile.Create(string, int, FileOptions) does and then also set the security on the MockFileData.

Whether or not security is enforced anywhere else is unrelated. If a security mechanism would prevent us from creating the file, that would be implemented by Create(string) or wherever else, but not in this overload.

[fgreinacher]

That sounds sensible. Thanks for the reasoning!

[benkoshy]

hi there

I'm made an attempt at this overload, but not sure if i'm doing it right: Would any of you have a glance over the following code and advise? if happy with this, i can put in a PR.

        public override Stream Create(string path, int bufferSize, FileOptions options, FileSecurity fileSecurity)
        {
            if (path == null)
            {
                throw new ArgumentNullException(nameof(path), "Path cannot be null.");
            }
            mockFileDataAccessor.PathVerifier.IsLegalAbsoluteOrRelative(path, "path");

            var directoryPath = mockPath.GetDirectoryName(path);
            if (!mockFileDataAccessor.Directory.Exists(directoryPath))
            {
                throw new DirectoryNotFoundException(string.Format(CultureInfo.InvariantCulture, StringResources.Manager.GetString("COULD_NOT_FIND_PART_OF_PATH_EXCEPTION"), path));
            }

            MockFileData mockFileData = new MockFileData(new byte[bufferSize]); // should the buffer size be added here?
            mockFileDataAccessor.AddFile(path, mockFileData);
            mockFileData.AccessControl = fileSecurity; // TODO:  should we check whether the fileSecurity object has any FileSystem access rules added to it? otherwise it might not make much sense.
            var stream = OpenWrite(path);
            return stream;
        }

// TEST

        [Test]
        public void Mockfile_CreateOverload_ShouldCreateNewStream()
        {
            string fullPath = XFS.Path(@"c:\something\demo.txt");
            var fileSystem = new MockFileSystem();
            fileSystem.AddDirectory(XFS.Path(@"c:\something"));
            FileSecurity fileSecurity = new FileSecurity();
            FileOptions fileOption = FileOptions.WriteThrough;

            var mockFile = new MockFile(fileSystem);

            Assert.That(fileSystem.FileExists(fullPath), Is.False);

            mockFile.Create(fullPath, 20, fileOption, fileSecurity).Dispose();

            Assert.That(fileSystem.FileExists(fullPath), Is.True);
        }

[rkoeninger]

@BKSpurgeon if you haven't seen it already, I hashed out some code for what I thought this would look like here.

[benkoshy]

Trying to get the FileOptions implemented. Is the .net code something that is looked to in implemented this: https://referencesource.microsoft.com/#mscorlib/system/io/filestream.cs,76ef6c04de9d0ed8,references

wanting some advice on how it is actually implemented. if you know pls advise.

[rkoeninger]

@BKSpurgeon I was thinking support for FileOptions would be done in #332. #332 should be done before this one and #331 should be done before #332. Each builds on the other. Maybe start with #331,

[benkoshy]

@rkoeninger ok i'll give #331 a good shot. rgds Ben