Updates the Mock File System to throw DirectoryNotFound if creating a… #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file in a directory that does not exist. When creating a file in a real file system on Windows, if the filename is in a directory that does not exist, a DirectoryNotFoundException would be thrown. This change, causes the MockFile to behave in the same way. Additionally some other tests had to be updated. These tests did not tell the mock filesystem that the directory existed before attempting the create.
Contributor
Author
|
This request resolves the issue #278 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… file in a directory that does not exist.
When creating a file in a real file system on Windows, if the filename is in a directory that does not exist, a DirectoryNotFoundException would be thrown. This change, causes the MockFile to behave in the same way.
Additionally some other tests had to be updated. These tests did not tell the mock filesystem that the directory existed before attempting the create.