-
Notifications
You must be signed in to change notification settings - Fork 267
Add SourceLink #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SourceLink #326
Conversation
|
Any objections on merging this? |
|
This actually seems really cool. This has always been a big issue at my place of work (the need to debug packages), and we've always had to do some pretty big heroics to get that functionality. For this, all I'd want to do is test it. Intentionally break something in the library, create a local package, reference said package, and see what the debugging story is like. |
|
Hm.. I'm no longer able to create a NuGet package when I checkout this branch locally (dotnet pack). The error is quite lengthy, but here's a snippet. C:\Users\jpree.nuget\packages\microsoft.build.tasks.git\1.0.0-beta-63102-01\build\Microsoft.Build.Tasks.Git.targets(20,5): error MSB4018: The "Microsoft.Build.Tasks.Git.LocateRepository" task failed unexpectedly.\r [C:\Users\jpree\Desktop\System.IO.Abstractions\System.IO.Abstractions\System.IO.Abstractions.csproj] |
|
Do you have .NET Core SDK 2.1.300? This seems so be the minimum supported version as per dotnet/sourcelink#107 |
Co-Authored-By: fgreinacher <fgreinacher@users.noreply.github.com>

This PR adds SourceLink support to our assemblies/PDBs.
I verified it using
sourcelink testas per the documentation and everything looks good.