Call base.Close() in MockFileStream.Close() #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltiple calls to Close() throwing)
robkeim
reviewed
Nov 9, 2018
robkeim
reviewed
Nov 9, 2018
robkeim
approved these changes
Nov 9, 2018
Contributor
robkeim
left a comment
robkeim
left a comment
There was a problem hiding this comment.
Changes look good to me @biltongza!
Contributor
Author
|
Cool! Any chance of getting a beta with this in it? I need this to fix a failing test at work :) |
Contributor
|
@biltongza I'll defer to some of the main contributors on that @fgreinacher and @jpreese can you guys weigh in? |
Contributor
|
LGTM, thanks for your contribution! |
Contributor
|
@biltongza Will be available at https://www.nuget.org/packages/System.IO.Abstractions.TestingHelpers/2.2.8-beta in some minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #397.