Fix file operations that fail when used with relative paths #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgreinacher
changed the title
fgreinacher
changed the title
Contributor
Author
fgreinacher
commented
Nov 27, 2018
| { | ||
| // Arrange | ||
| var fileSystem = new MockFileSystem(); | ||
| var file = XFS.Path("C:\\path\\NotFound.ext"); |
Contributor
Author
There was a problem hiding this comment.
This test was not normalizing the path which caused test failures on Unix, so I fixed this.
fgreinacher
commented
Nov 27, 2018
| TestDelegate action = () => fileSystem.File.Create(file); | ||
|
|
||
| // Assert | ||
| Assert.IsFalse(fileSystem.Directory.Exists("C:\\path")); |
Contributor
Author
There was a problem hiding this comment.
This doesn't belong in this test case so I decided to remove it.
fgreinacher
commented
Nov 27, 2018
| { | ||
| // Arrange | ||
| var fileSystem = new MockFileSystem(); | ||
| var file = XFS.Path("C:\\path\\NotFound.ext"); |
Contributor
Author
There was a problem hiding this comment.
Same comment as above
fgreinacher
commented
Nov 27, 2018
| TestDelegate action = () => fileSystem.File.Open(file, FileMode.Create); | ||
|
|
||
| // Assert | ||
| Assert.IsFalse(fileSystem.Directory.Exists("C:\\path")); |
Contributor
Author
There was a problem hiding this comment.
Same comment as above
Contributor
|
@fgreinacher Looks good to me! |
robkeim
approved these changes
Nov 28, 2018
Contributor
robkeim
left a comment
robkeim
left a comment
There was a problem hiding this comment.
Changes look good to me, thanks @fgreinacher!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause for the problems is wleader@95ead3a#diff-e76db4b13ed41e41943b80f8f1075287 where we started using
Path.GetDirectoryNameto get the parent directory, but unfortunately this method returns an empty string when the path does not contain directory information (e.g. a plain file name).The changes here make the paths absolute before passing them on to
Path.GetDirectoryName.Fixes #404 and #401