Bug/428 mockdirectory delete #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgreinacher
suggested changes
Jan 1, 2019
Contributor
fgreinacher
left a comment
fgreinacher
left a comment
There was a problem hiding this comment.
Thanks a lot! Will merge as soon as my comments are addressed.
| } | ||
|
|
||
| [Test] | ||
| [WindowsOnly(WindowsSpecifics.CaseInsensitivity)] |
Contributor
There was a problem hiding this comment.
Why is this test windows-only? I don't see anything windows-specific in there.
| public void MockDirectory_Delete_ShouldNotDeleteAllDirectories() | ||
| { | ||
| // Arrange | ||
| var folder1Path = @"D:\Test\Program"; |
Contributor
There was a problem hiding this comment.
If you create the path strings via XFS.Path("...") it will work x-plat.
fgreinacher
approved these changes
Jan 5, 2019
Contributor
|
@updateaman I added some commits to make the tests work cross-platform. Merging as soon as CI is green. Thanks a lot for your contribution! |
Merged
fgreinacher
added a commit
that referenced
this pull request
Jan 5, 2019
- Do not throw exception when calling DirectoryInfoWrapper.Parent for the root directory (#430) by @wexman - Fix MockDirectoryInfo GetFiles for UNC paths caused by bug in StringExtensions.NormalizeSlashes (#422) by @DeveloperGuo - Pass IFileSystem into FileWrapper instead of FileSystem to allow replacement file systems to be used (#432) by @kirbatious - Make sure FileNotFound exceptions contain path and proper message (#427) by @fgreinacher - Do not delete directories that start with the same path (#433) by @updateaman
Contributor
Author
|
Thank you for sorting this out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for bug #428
Fixed the bug where Directory.Delete was deleting all similarly named directories.
Now it will only delete the directory and subdirectories