Skip to content

Added HResult value for ERROR_SHARING_VIOLATION to File in use exception #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fgreinacher merged 2 commits into from
Apr 3, 2019
Merged

Added HResult value for ERROR_SHARING_VIOLATION to File in use exception #462

fgreinacher merged 2 commits into from
Apr 3, 2019

Conversation

@roketworks
Copy link
Contributor

@roketworks roketworks commented Apr 2, 2019

This resolves issue #461

@fgreinacher
Copy link
Contributor

fgreinacher commented Apr 2, 2019

Thanks! Please add unit tests and we‘re good to go!

@roketworks
Copy link
Contributor Author

roketworks commented Apr 3, 2019

Thanks! Please add unit tests and we‘re good to go!

I've added to MockFileLockTests, so where IOException is returned it will check to make to make sure the HResult property is correct. I thought this made more sense than a single test that only tests the exception under 1 condition.

@fgreinacher
Copy link
Contributor

fgreinacher commented Apr 3, 2019

Perfect, thanks again!

@fgreinacher fgreinacher merged commit fcf6394 into TestableIO:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roketworks @fgreinacher