Truncate existing files when writing via FileMode.Create/CreateNew #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| using(var stream = fileSystem.FileStream.Create(FilePath, fileMode, System.IO.FileAccess.Write)) | ||
| { | ||
| using(var writer = new System.IO.StreamWriter(stream, System.Text.Encoding.UTF8, 4096, leaveOpen: true)) |
Contributor
There was a problem hiding this comment.
There are problems in appveyor tests because NET40 didn't have constructor that support leaveOpen parameter.
To fix that you can make conditional scenario for #if NET40 to get same react just don't create writer in using so Dispose will not be run.
But please someone confirm that what i write make sense.
Contributor
There was a problem hiding this comment.
I’d suggest just removing this argument, it does not seem to be necessary here. Same for the buffer size.
Contributor
There was a problem hiding this comment.
Or even get rid of the StreamWriter and just write directly to the Stream.
fgreinacher
changed the title
Contributor
|
Thanks @tomwilde! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #465