Fixes an issue with trailing spaces on directory path for Windows. #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2019 16:36
…tform. On Windows, trailing spaces are automatically removed from directory name.
fgreinacher
suggested changes
Jun 5, 2019
Contributor
fgreinacher
left a comment
fgreinacher
left a comment
There was a problem hiding this comment.
Two minor nits, otherwise 🎉
System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryInfoTests.cs
Outdated
Show resolved
Hide resolved
System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryInfoTests.cs
Outdated
Show resolved
Hide resolved
System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryInfoTests.cs
Outdated
Show resolved
Hide resolved
fgreinacher
approved these changes
Jun 16, 2019
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
On Windows, trailing spaces are automatically removed from directory name.
If I create a directory like that
var dirInfo = System.IO.Directory.CreateDirectory(@"C:\User\Folder ");Then
dirInfo.Name == "Folder"should be true.