fix: pluralize item suffix in ComplyWith failure messages#951
Merged
Conversation
The ComplyWith constraints hardcoded ` items` (always plural), producing ungrammatical output like `for exactly one items`. Route the suffix through EnumerableQuantifier.GetItemString() like the other collection constraints, so singular quantifiers (Exactly(1), AtLeast(1), AtMost(1)) render `item` instead. Also adds verification tests for the Exactly(n).ComplyWith chain and the AtLeast(n).ComplyWith chain, which previously had no coverage.
There was a problem hiding this comment.
Pull request overview
Fixes ungrammatical ComplyWith failure messages (e.g., “for exactly one items”) by routing the item suffix through EnumerableQuantifier.GetItemString() so singular quantifiers render item instead of items.
Changes:
- Updated
ThatEnumerable.Elements.ComplyWithandThatAsyncEnumerable.Elements.ComplyWithexpectation formatting to useGetItemString()foritem/items. - Removed the now-unneeded
ComplyItemsconstant fromThatEnumerable. - Added new unit tests for
Exactly(n).ComplyWith(...)andAtLeast(n).ComplyWith(...)chains.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Tests/aweXpect.Tests/Collections/ThatEnumerable.Exactly.ComplyWith.Tests.cs | Adds coverage for Exactly(...).ComplyWith(...) and AtLeast(...).ComplyWith(...) scenarios (including a singular-message assertion for Exactly(1)). |
| Source/aweXpect/That/Collections/ThatEnumerable.Elements.ComplyWith.cs | Uses EnumerableQuantifier.GetItemString() instead of hardcoded " items" in expectation text. |
| Source/aweXpect/That/Collections/ThatEnumerable.cs | Removes the obsolete ComplyItems constant. |
| Source/aweXpect/That/Collections/ThatAsyncEnumerable.Elements.ComplyWith.cs | Aligns async ComplyWith expectation text with the singular/plural logic via GetItemString(). |
Contributor
Test Results 23 files - 27 23 suites - 27 7m 49s ⏱️ -4s Results for commit 3f0d619. ± Comparison against base commit 16e2c24. This pull request removes 3166 and adds 3158 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
vbreuss
changed the title
ComplyWith failure messages
|
Contributor
🚀 Benchmark ResultsDetails
|
Contributor
👽 Mutation ResultsaweXpectDetails
The final mutation score is 80.82%Coverage Thresholds: high:80 low:60 break:0aweXpect.CoreDetails
The final mutation score is NaN%Coverage Thresholds: high:80 low:60 break:0 |
github-actions Bot
added a commit
that referenced
this pull request
May 16, 2026
…th` failure messages (#951) by Valentin Breuß
github-actions Bot
added a commit
that referenced
this pull request
May 16, 2026
…th` failure messages (#951) by Valentin Breuß
Contributor
|
This is addressed in release v2.34.0. |
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ComplyWith constraints hardcoded
items(always plural), producing ungrammatical output likefor exactly one items. Route the suffix through EnumerableQuantifier.GetItemString() like the other collection constraints, so singular quantifiers (Exactly(1), AtLeast(1), AtMost(1)) renderiteminstead.Also adds verification tests for the Exactly(n).ComplyWith chain and the AtLeast(n).ComplyWith chain, which previously had no coverage.