fix: use Environment.NewLine in AppendIsIncomplete failure messages#966
Merged
Conversation
…es (#965) Two return paths in `AppendIsIncomplete` were C# raw-string literals whose newlines are embedded at compile time from the source file's line endings. The official NuGet builds on Linux (LF), but the surrounding `Formatter.Format` output uses `Environment.NewLine` at runtime — so Windows consumers got messages with mixed `\r\n` and bare `\n` in the "(… and maybe others)" block. Replace the raw strings with explicit concatenation using `Environment.NewLine` so the appended newlines match what `Formatter.Format` already produces.
There was a problem hiding this comment.
Pull request overview
Fixes mixed line-ending output in AppendIsIncomplete by replacing raw-string literals (whose newlines are baked in at compile time from source file EOLs) with explicit concatenation using Environment.NewLine, ensuring consistent newlines regardless of build host vs. runtime OS.
Changes:
- Replace two raw-string returns with
Environment.NewLine-based concatenation. - Leaves the third return (single-line, no embedded newline) unchanged.
|
Contributor
Test Results 23 files - 27 23 suites - 27 8m 50s ⏱️ +34s Results for commit 89386ce. ± Comparison against base commit a9e05ce. This pull request removes 3195 and adds 3168 tests. Note that renamed tests count towards both. |
github-actions Bot
added a commit
that referenced
this pull request
May 18, 2026
…ndIsIncomplete` failure messages (#966) by Valentin Breuß
github-actions Bot
added a commit
that referenced
this pull request
May 18, 2026
…ndIsIncomplete` failure messages (#966) by Valentin Breuß
Contributor
🚀 Benchmark ResultsDetails
|
Contributor
👽 Mutation ResultsaweXpectDetails
The final mutation score is 92.78%Coverage Thresholds: high:80 low:60 break:0aweXpect.CoreDetails
The final mutation score is NaN%Coverage Thresholds: high:80 low:60 break:0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two return paths in
AppendIsIncompletewere C# raw-string literals whose newlines are embedded at compile time from the source file's line endings. The official NuGet builds on Linux (LF), but the surroundingFormatter.Formatoutput usesEnvironment.NewLineat runtime — so Windows consumers got messages with mixed\r\nand bare\nin the "(… and maybe others)" block.Replace the raw strings with explicit concatenation using
Environment.NewLineso the appended newlines match whatFormatter.Formatalready produces.AppendIsIncompleteemits inconsistent line endings in failure messages #965