Remove unused member from eddsa algorithm base #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prince-chrismc
commented
Mar 20, 2021
Thalhammer
approved these changes
Mar 20, 2021
Closed
prince-chrismc
added a commit
to prince-chrismc/jwt-cpp
that referenced
this pull request
May 16, 2021
* Remove unused member from eddsa algorithm base (Thalhammer#136) * Remove unsed memember from eddsa algotithm base * docs * Remove silly test code * 🐛 Fix warning C4267 from STL to OpenSSL API (Thalhammer#141) * Changed the JWT_CMAKE_FILES_INSTALL_DIR such that it is found on both Windows and Unix and that it may be configured to something entirely different * Update CMakeLists.txt Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Update .github/workflows/cmake.yml Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Update .github/workflows/cmake.yml Co-authored-by: Chris Mc <prince.chrismc@gmail.com> * Update .github/workflows/cmake.yml Co-authored-by: Chris Mc <prince.chrismc@gmail.com> Co-authored-by: Arjen Hoogesteger <arjen.hoogesteger@sweco.nl> Co-authored-by: Arjen Hoogesteger <65287900+sweco-nlahoo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #134
Minor API break but I doubt anyone is using the base class.
Additional Information ℹ️