Skip to content

Conversation

@kleinmrk
Copy link
Contributor

@kleinmrk kleinmrk commented Dec 5, 2021

Addresses #150

I tried my best to not introduce any new #ifdefs but I did not find any common non-deprecated interface for validating ECDSA public and private keys. These also propagated to OpenSSLErrorTest.cpp.

@prince-chrismc
Copy link
Collaborator

I've looked this over twice but I need to check it out and take time to learn the new version of OpenSSL.

@prince-chrismc
Copy link
Collaborator

prince-chrismc commented Dec 12, 2021

I realized you fixed all of them 🎉so I added a job to make sure we don't regress

tested on my fork but this
https://github.com/Thalhammer/jwt-cpp/runs/4499088251?check_suite_focus=true should pass

(last commit on master for comparison https://github.com/Thalhammer/jwt-cpp/runs/4295140405?check_suite_focus=true#step:7:7)

@prince-chrismc prince-chrismc linked an issue Dec 12, 2021 that may be closed by this pull request
@prince-chrismc prince-chrismc merged commit 275c750 into Thalhammer:master Dec 12, 2021
@kleinmrk kleinmrk deleted the replace-deprecated-functions branch January 9, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eliminate deprecations warnings with OpenSSL 3

2 participants