Skip to content

Comments

Feature Task Integration#12

Merged
The-Compiler merged 3 commits intoThe-Compiler:mainfrom
The-V8:feature/task-integration
Jul 6, 2022
Merged

Feature Task Integration#12
The-Compiler merged 3 commits intoThe-Compiler:mainfrom
The-V8:feature/task-integration

Conversation

@dariuszparys
Copy link

This PR introduces a tox task provider implementation to enable tox tasks to be executed within vscode tasks. This PR is a base for the discussion in #5.

Dariusz Parys added 3 commits April 7, 2022 11:38
Adding a tox task provider to allow selection of testenvs
through the task run interface of vscode
- Included a test to invoke the ToxTaskProvider class
- Camel cased constants to satisfy linter
- Refactored ToxTaskProvider tests into separate test suite
- Moved getExampleDir into utils.ts it is used from both test suites
- Fixed test with adding a workspace creation in order to retrieve tox tasks
via the task provider
@The-Compiler The-Compiler merged commit 482c471 into The-Compiler:main Jul 6, 2022
@The-Compiler
Copy link
Owner

After a break (due to COVID... but feeling much better now!) I'm back to merging PRs. This looks great, I only pushed a couple of simplifications I noticed in the process of reading the code:

  • 098923f task provider: Improve promises handling
  • 569384b task provider: Small simplifications

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants