clang-tidy: ignore boost headers for now.#9457
Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Feb 11, 2026
Merged
clang-tidy: ignore boost headers for now.#9457maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
They are often meant to be included as a single header that then internally includes all the internal headers. However, the single headers don't provide the necessary IWYU annotations for `misc-include-cleaner` to give proper guidance. So for now, misc-include-cleaner warnings w.r.t. boost are more noise then useful. I have a few boost upstream PRs open, but it either goes slow to review, or they require met to show that it is helping, which I didn't have time to yet. Even once all these are merged, we need to wait for them to show up in a released version. (e.g. boostorg/geometry#1427 boostorg/beast#3027 ) Signed-off-by: Henner Zeller <h.zeller@acm.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the .clang-tidy configuration to ignore Boost headers for the misc-include-cleaner check. This is a reasonable temporary solution to reduce linter noise while waiting for upstream fixes in Boost. The change is straightforward, but I have a small suggestion to make the pattern matching more robust and consistent with the other ignored header patterns in the file.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are often meant to be included as a single
header that then internally includes all the
internal headers.
However, the single headers don't provide the necessary IWYU annotations for
misc-include-cleanerto give proper guidance. So for now, misc-include-cleaner warnings w.r.t. boost are more noise than useful.I have a few boost upstream PRs open, but it either goes slow to review, or they require met to show that it is helping, which I didn't have time to yet.
Even once all these are merged, we need to wait for them to show up in a released version.
(e.g.
boostorg/geometry#1427
boostorg/beast#3027
)