algorithm: Pronic number #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsAkshayDubey
requested review from
raklaptudirm,
siriak,
tjgurwara99 and
yanglbme
as code owners
vil02
reviewed
Oct 27, 2022
raklaptudirm
requested changes
Oct 27, 2022
raklaptudirm
previously approved these changes
Oct 28, 2022
vil02
suggested changes
Oct 28, 2022
tjgurwara99
requested changes
Oct 30, 2022
Contributor
Author
|
@tjgurwara99 and @vil02 I added all the suggested changes. Thanks, |
vil02
suggested changes
Nov 7, 2022
Member
vil02
left a comment
vil02
left a comment
There was a problem hiding this comment.
There is some overflow issue. Interesting.
itsAkshayDubey
requested review from
raklaptudirm,
tjgurwara99 and
vil02
and removed request for
tjgurwara99 and
vil02
vil02
reviewed
Nov 8, 2022
Member
vil02
left a comment
vil02
left a comment
There was a problem hiding this comment.
Looks good to me, besides the name in the test cases.
tjgurwara99
requested changes
Nov 8, 2022
itsAkshayDubey
requested review from
raklaptudirm,
tjgurwara99 and
vil02
and removed request for
raklaptudirm,
tjgurwara99 and
vil02
vil02
reviewed
Nov 9, 2022
vil02
approved these changes
Nov 10, 2022
tjgurwara99
approved these changes
Nov 10, 2022
raklaptudirm
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains commits related to pronic number implementation.
Thanks.