Iterative fibonacci with unittests from slash #882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two ways to calculate the fibonacci sequence: (1) iterative (2) formula. I've also added a timer decorator so someone can see the difference in computation time between these two methods. Added two unittests using the slash framework.
…roblem_01/sol6.py
poyea
approved these changes
Jun 8, 2019
Member
poyea
left a comment
poyea
left a comment
There was a problem hiding this comment.
There's no need to separate tests out, but I'd merge this as this is indeed a new approach.
Thank you for your pull request!🤩
This was referenced Jun 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of the request #866 , I couldn't figure how to add it to the request, so I'm creating a new pull request. I've included the changes using the iterative fibonacci. First pull request, so any feedback is appreciated :D.
--Added two ways to calculate the fibonacci sequence: (1) iterative (2) formula.
--I've also added a timer decorator so someone can see the difference in computation time between these two methods.
--Added two unittests using the slash framework.