This repository was archived by the owner on Nov 8, 2022. It is now read-only.
DAPS-761 From PIVX Upstream: [Qt] Remove Qt4 build support & code fallbacks#798
Closed
lyricidal wants to merge 1 commit into
Closed
DAPS-761 From PIVX Upstream: [Qt] Remove Qt4 build support & code fallbacks#798lyricidal wants to merge 1 commit into
lyricidal wants to merge 1 commit into
Conversation
2 files did not require editing from the commit this was based on: src/qt/bantablemodel.cpp src/qt/sendcoinsentry.cpp
lyricidal
requested review from
DecentralizedSolutions,
pedrorv0106 and
pvc2104
lyricidal
added
Upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We haven't actually supported Qt4 in a very very long time. The build system still recognized it as "valid", but compile time always threw errors.
This removes the validity of Qt4 from the configure script, as well as removes no-longer-needed conditionals in the source code.
For reference, Qt4 was EOL'd back in 2015, and even if we didn't already have strict requirements for using Qt5, there would be no real justification in continuing to have Qt4 fallbacks.
PIVX-Project/PIVX#698
2 files did not require editing from the commit this was based on:
src/qt/bantablemodel.cpp
src/qt/sendcoinsentry.cpp