Bug in BowSpell maximum-force

[jeussa]

Confirmation:

• My server is supported by MagicSpells.
• This bug occurs on PaperMC itself, not just its forks which I might be using.

Intended outcome:

Leaving the "maximum-force" parameter in a BowSpell blank should disable any upper-limit force checks of the spell.

Actual outcome:

Leaving the "maximum-force" parameter in a BowSpell blank makes the plugin default it to 1.0. In modern versions of Minecraft, the force tends to exceed 1.0 causing the spell to block when no value is given.

Reproduction steps:

No response

Errors:

Relevant configuration:

MagicSpells version:

4.0-Beta-16

Minecraft server version:

PaperMC 1.21.4

Relevant plugins:

No response

[JasperLorelai]

Based on a Paper bug report (PaperMC/Paper#10640), we are comparing against a value named "force", which after some MC update has not been returning the bow tension force 0-1 but the shoot event speed. The bow speed is multiplied by 3. They have to fix that inconsistency in value or documentation.

The max force also differs for crossbows, being 1.6 for piglins and pillagers, 3.15 with fireworks. So, our part of this fix is to do what you said, and not check the max force by default.

Since this fix will only be applied once updated to 4.0 Beta 17, for the moment use:

maximum-force: 3 #remove line in 4.0 Beta 17

[JasperLorelai]

PaperMC/Paper#12308 fixes force to not refer to speed, but the [0, 1] tension interval.

[TonytheMacaroni]

The linked Paper PR has been merged, and the issue seems to no longer be present.