Commands /f promote, /f kick doesn't work

[SuperAlecs]

Im using the latest branch of "beta"

[ZPlayzMCPE]

Can you please describe what it says when using /f kick and /f promote? Any errors, crashdumbs, etc? If so, please send it here. It'll help for me to fix the bug. Thanks.

[ZPlayzMCPE]

This bug should be fixed. Please test it, and let me know if the issue's fixed or not. Thanks. Issue closed.

[SuperAlecs]

I tested and it isnt fixxed

/f promote:
[16:08:39] [Server thread/CRITICAL]: Unhandled exception executing command 'f promote nickstryk3' in f: Undefined variable: player
[16:08:39] [Server thread/CRITICAL]: ErrorException: "Undefined variable: player" (EXCEPTION) in "FactionsPro-master/src/FactionsPro/FactionCommands" at line 266
[16:08:39] [Server thread/DEBUG]: #0 FactionsPro-master/src/FactionsPro/FactionCommands(266): pocketmine\error_handler(integer 8, string Undefined variable: player, string /root/server/opfactions/plugins/FactionsPro-master/src/FactionsPro/FactionCommands.php, integer 266, array Array())
[16:08:39] [Server thread/DEBUG]: #1 FactionsPro-master/src/FactionsPro/FactionMain(133): FactionsPro\FactionCommands->onCommand(pocketmine\Player object, pocketmine\command\PluginCommand object, string f, array Array())
[16:08:39] [Server thread/DEBUG]: #2 src/pocketmine/command/PluginCommand(58): FactionsPro\FactionMain->onCommand(pocketmine\Player object, pocketmine\command\PluginCommand object, string f, array Array())
[16:08:39] [Server thread/DEBUG]: #3 src/pocketmine/command/SimpleCommandMap(258): pocketmine\command\PluginCommand->execute(pocketmine\Player object, string f, array Array())
[16:08:39] [Server thread/DEBUG]: #4 src/pocketmine/Server(1946): pocketmine\command\SimpleCommandMap->dispatch(pocketmine\Player object, string f promote nickstryk3)
[16:08:39] [Server thread/DEBUG]: #5 src/pocketmine/Player(2190): pocketmine\Server->dispatchCommand(pocketmine\Player object, string f promote nickstryk3)
[16:08:39] [Server thread/DEBUG]: #6 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(222): pocketmine\Player->chat(string /f promote nickstryk3)
[16:08:39] [Server thread/DEBUG]: #7 src/pocketmine/network/mcpe/protocol/CommandRequestPacket(54): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleCommandRequest(pocketmine\network\mcpe\protocol\CommandRequestPacket object)
[16:08:39] [Server thread/DEBUG]: #8 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(92): pocketmine\network\mcpe\protocol\CommandRequestPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
[16:08:39] [Server thread/DEBUG]: #9 src/pocketmine/network/mcpe/protocol/BatchPacket(114): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\CommandRequestPacket object)
[16:08:39] [Server thread/DEBUG]: #10 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(92): pocketmine\network\mcpe\protocol\BatchPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
[16:08:39] [Server thread/DEBUG]: #11 src/pocketmine/Player(3038): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
[16:08:39] [Server thread/DEBUG]: #12 src/pocketmine/network/mcpe/RakLibInterface(153): pocketmine\Player->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
[16:08:39] [Server thread/DEBUG]: #13 vendor/pocketmine/raklib/server/ServerHandler(98): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string 2.44.24.83 57177, raklib\protocol\EncapsulatedPacket object, integer 0)
[16:08:39] [Server thread/DEBUG]: #14 src/pocketmine/network/mcpe/RakLibInterface(94): raklib\server\ServerHandler->handlePacket()
[16:08:39] [Server thread/DEBUG]: #15 src/pocketmine/network/Network(89): pocketmine\network\mcpe\RakLibInterface->process()
[16:08:39] [Server thread/DEBUG]: #16 src/pocketmine/Server(2495): pocketmine\network\Network->processInterfaces()
[16:08:39] [Server thread/DEBUG]: #17 src/pocketmine/Server(2243): pocketmine\Server->tick()
[16:08:39] [Server thread/DEBUG]: #18 src/pocketmine/Server(2119): pocketmine\Server->tickProcessor()
[16:08:39] [Server thread/DEBUG]: #19 src/pocketmine/Server(1701): pocketmine\Server->start()
[16:08:39] [Server thread/DEBUG]: #20 src/pocketmine/PocketMine(305): pocketmine\Server->__construct(BaseClassLoader object, pocketmine\utils\MainLogger object, string /root/server/opfactions/, string /root/server/opfactions/plugins/)

/f kick:

[16:09:21] [Server thread/CRITICAL]: Unhandled exception executing command 'f kick n' in f: Undefined variable: player
[16:09:21] [Server thread/CRITICAL]: ErrorException: "Undefined variable: player" (EXCEPTION) in "FactionsPro-master/src/FactionsPro/FactionCommands" at line 331
[16:09:21] [Server thread/DEBUG]: #0 FactionsPro-master/src/FactionsPro/FactionCommands(331): pocketmine\error_handler(integer 8, string Undefined variable: player, string /root/server/opfactions/plugins/FactionsPro-master/src/FactionsPro/FactionCommands.php, integer 331, array Array())
[16:09:21] [Server thread/DEBUG]: #1 FactionsPro-master/src/FactionsPro/FactionMain(133): FactionsPro\FactionCommands->onCommand(pocketmine\Player object, pocketmine\command\PluginCommand object, string f, array Array())
[16:09:21] [Server thread/DEBUG]: #2 src/pocketmine/command/PluginCommand(58): FactionsPro\FactionMain->onCommand(pocketmine\Player object, pocketmine\command\PluginCommand object, string f, array Array())
[16:09:21] [Server thread/DEBUG]: #3 src/pocketmine/command/SimpleCommandMap(258): pocketmine\command\PluginCommand->execute(pocketmine\Player object, string f, array Array())
[16:09:21] [Server thread/DEBUG]: #4 src/pocketmine/Server(1946): pocketmine\command\SimpleCommandMap->dispatch(pocketmine\Player object, string f kick n)
[16:09:21] [Server thread/DEBUG]: #5 src/pocketmine/Player(2190): pocketmine\Server->dispatchCommand(pocketmine\Player object, string f kick n)
[16:09:21] [Server thread/DEBUG]: #6 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(222): pocketmine\Player->chat(string /f kick n)
[16:09:21] [Server thread/DEBUG]: #7 src/pocketmine/network/mcpe/protocol/CommandRequestPacket(54): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleCommandRequest(pocketmine\network\mcpe\protocol\CommandRequestPacket object)
[16:09:21] [Server thread/DEBUG]: #8 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(92): pocketmine\network\mcpe\protocol\CommandRequestPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
[16:09:21] [Server thread/DEBUG]: #9 src/pocketmine/network/mcpe/protocol/BatchPacket(114): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\CommandRequestPacket object)
[16:09:21] [Server thread/DEBUG]: #10 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(92): pocketmine\network\mcpe\protocol\BatchPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
[16:09:21] [Server thread/DEBUG]: #11 src/pocketmine/Player(3038): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
[16:09:21] [Server thread/DEBUG]: #12 src/pocketmine/network/mcpe/RakLibInterface(153): pocketmine\Player->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
[16:09:21] [Server thread/DEBUG]: #13 vendor/pocketmine/raklib/server/ServerHandler(98): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string 2.44.24.83 57177, raklib\protocol\EncapsulatedPacket object, integer 0)
[16:09:21] [Server thread/DEBUG]: #14 src/pocketmine/network/mcpe/RakLibInterface(96): raklib\server\ServerHandler->handlePacket()
[16:09:21] [Server thread/DEBUG]: #15 src/pocketmine/network/Network(89): pocketmine\network\mcpe\RakLibInterface->process()
[16:09:21] [Server thread/DEBUG]: #16 src/pocketmine/Server(2495): pocketmine\network\Network->processInterfaces()
[16:09:21] [Server thread/DEBUG]: #17 src/pocketmine/Server(2243): pocketmine\Server->tick()
[16:09:21] [Server thread/DEBUG]: #18 src/pocketmine/Server(2119): pocketmine\Server->tickProcessor()
[16:09:21] [Server thread/DEBUG]: #19 src/pocketmine/Server(1701): pocketmine\Server->start()
[16:09:21] [Server thread/DEBUG]: #20 src/pocketmine/PocketMine(305): pocketmine\Server->__construct(BaseClassLoader object, pocketmine\utils\MainLogger object, string /root/server/opfactions/, string /root/server/opfactions/plugins/)

[iZeaoGamer]

Okay, it’s now fixed. Please check to see if it’s fixed or not.

[SuperAlecs]

It's fixxed thanks for the help, I also found another bug trying to check the previous bug, you can promote yourself even if you are a leader so you became an officer

[TheFixerDevelopment]

Anytime, and please be a bit more specific.

[TheFixerDevelopment]

Infact, create a new issue, and we'll discuss it there.