Refactor game ID handling in controller and validation schemas#169
Merged
Uttkarsh24 merged 3 commits intoTheGradients:mainfrom Feb 18, 2025
Merged
Refactor game ID handling in controller and validation schemas#169Uttkarsh24 merged 3 commits intoTheGradients:mainfrom
Uttkarsh24 merged 3 commits intoTheGradients:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to standardize the field names used in various game ID-related functions and validation schemas across the codebase. The main change involves replacing specific game ID fields with a more generic
gameIDfield.Changes to
game.controller.js:addBgmiIdfunction to usegameIDinstead ofbgmiIdfor consistency.addFreeFireIdfunction to usegameIDinstead offreeFireId.addValorantIdfunction to usegameIDinstead ofvalorantId, and updated the nested properties accordingly.addCodmIdfunction to usegameIDinstead ofcodmId.addAsphaltIdfunction to usegameIDinstead ofasphaltId.Changes to
gameValidatorSchema.js:gameIDinstead of specific game ID fields likebgmiId,freeFireId,valorantId,codmId, andasphaltId.