Enable static component registration in application executables#7194
Merged
hkaiser merged 1 commit intoTheHPXProject:masterfrom Apr 19, 2026
Merged
Enable static component registration in application executables#7194hkaiser merged 1 commit intoTheHPXProject:masterfrom
hkaiser merged 1 commit intoTheHPXProject:masterfrom
Conversation
Signed-off-by: Abhishek Bansal <abhibansal593@gmail.com>
|
Can one of the admins verify this patch? |
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #7180
Proposed Changes
Remove the app-exe gate so the ctors fire in application TUs as well, mirroring what Add static plugin loading support for HPX plugins #7180 did for plugin modules.
Link the new test against
hpx_runtime_configuration(nothpx_core):load_component_factory_staticis declaredHPX_CXX_CORE_EXPORT, which is only active under the C++20 modules build. In the default dynamic build, it resolves to empty, so the symbol is hidden inlibhpx_core.soby-fvisibility=hiddenbut remains globally visible in the per-module archive. Other tests in this directory already follow the same pattern.Checklist
Not all points below apply to all pull requests.