Make CURL dependency optional in tools/run/CMakeLists.txt#8
Merged
TheOriginalBytePlayer merged 3 commits intomasterfrom Jan 1, 2026
Merged
Make CURL dependency optional in tools/run/CMakeLists.txt#8TheOriginalBytePlayer merged 3 commits intomasterfrom
TheOriginalBytePlayer merged 3 commits intomasterfrom
Conversation
Co-authored-by: TheOriginalBytePlayer <18058224+TheOriginalBytePlayer@users.noreply.github.com>
Co-authored-by: TheOriginalBytePlayer <18058224+TheOriginalBytePlayer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix build issues related to missing CURL
Make CURL dependency optional in tools/run/CMakeLists.txt
Jan 1, 2026
TheOriginalBytePlayer
approved these changes
Jan 1, 2026
There was a problem hiding this comment.
Pull request overview
This PR makes the CURL dependency optional in tools/run/CMakeLists.txt to prevent build failures on Windows when CURL is unavailable, matching the fallback behavior already implemented in common/CMakeLists.txt.
- Removes
REQUIREDflag fromfind_package(CURL)to make CURL optional - Adds conditional fallback logic that disables CURL and emits a warning when CURL is not found
- Ensures
llama-runcan use cpp-httplib through thecommonlibrary when CURL is unavailable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CMake configuration fails on Windows when CURL is unavailable because
tools/run/CMakeLists.txtusesfind_package(CURL REQUIRED), whilecommon/CMakeLists.txtcorrectly makes CURL optional with cpp-httplib fallback.Changes:
REQUIREDflag fromfind_package(CURL)intools/run/CMakeLists.txtcommon/CMakeLists.txt: disable CURL when not found, emit warningllama-runuses cpp-httplib viacommonlibrary (already supported in code)The
run.cppimplementation already handles both code paths via conditional compilation (#ifdef LLAMA_USE_CURL).Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.