Fix warning in OPDS importer settings#1213
Merged
jonathangreen merged 1 commit intomainfrom Jun 22, 2023
Merged
Conversation
RishiDiwanTT
approved these changes
Jun 22, 2023
Contributor
RishiDiwanTT
left a comment
There was a problem hiding this comment.
I knew about this warning, and intended to fix it during the PR cleanup, but that got out of hand 😆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move the
_NO_DEFAULT_AUDIENCEto a private attribute.Motivation and Context
After #1189 was merged, I am seeing this warning in the logs when starting the CM:
Moving this to a private attribute means we won't see these warnings every time we start up the CM.
How Has This Been Tested?
Testing locally in docker container.
Checklist