Remove the directory importer script 🔥 (PP-213)#1345
Merged
jonathangreen merged 4 commits intomainfrom Aug 31, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1345 +/- ##
========================================
Coverage 89.90% 89.90%
========================================
Files 212 211 -1
Lines 28644 28459 -185
Branches 6538 6497 -41
========================================
- Hits 25752 25586 -166
+ Misses 1886 1881 -5
+ Partials 1006 992 -14
☔ View full report in Codecov by Sentry. |
jonathangreen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the directory importer script, since we are not using it anywhere, and have decided to host content like this elsewhere in the future.
Motivation and Context
Our database migration for #1189 failed on the Columbia staging server because it had an external integration configured with “Manual intervention“ as the protocol. This collection was added via the
directory_importscript. This script appears to create collections that cause problems with the new integration settings system.Instead of fixing this issue, we've decided to remove the script.
How Has This Been Tested?
Running tests.
Checklist