Open
Conversation
Israel-Laguan
requested changes
Nov 6, 2020
| import { Link } from "react-router-dom"; | ||
|
|
||
| export default class Navigation extends Component { | ||
| render() { |
Collaborator
There was a problem hiding this comment.
As this is only presentational, please change to Functional Component
| </Link> | ||
| </li> | ||
| <li className="nav-item"> | ||
| <Link className="nav-link" to="/api/v1/ticket"> |
Collaborator
There was a problem hiding this comment.
As I understand this URL is for requesting data, not to show a view (note it says "api")
Collaborator
There was a problem hiding this comment.
The same for the other ones
| import axios from "axios"; | ||
|
|
||
| export default class CreateUser extends Component { | ||
| async componentDidMount() { |
Collaborator
There was a problem hiding this comment.
Why is in componentDidMount if the form is for creating?
| return ( | ||
| <div> | ||
| <div className="container"> | ||
| <form> |
Collaborator
There was a problem hiding this comment.
Add a "preventDefault()" on submit or before to avoid faux-requests
Improving the installation documentation
Fixing require statements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mandar carpeta coolserver-