rph usb driver for 0.1.0 #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X6500, ZTEX: Fix PyUSB 0.4 compatibility issues
WebUI: Fix boolean enums
Merge testing branch changes (mostly bug fixes) to master
Owner
There was a problem hiding this comment.
Hm, we should solve this in a way that still ignores the pyusb folder that could be placed in the root directory.
No idea how exactly gitignore works here, could be easiest to just rename your worker module to something else...
Owner
|
Seems like this is mostly copy&pasted from one of my modules with just some changes to the actual USB commands in driver.py, so there is not much that could go wrong here. See line comments for some minor nitpicks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.