ci: bump npm before publish for OIDC trusted publishing#9
Merged
Conversation
Node 20 ships with npm 10.x, which predates trusted-publishing support. The v7.0.0-alpha.0 release hit E404 on PUT because the publish command fell back to the placeholder NODE_AUTH_TOKEN setup-node injects when no real token is configured. npm >= 11.5.1 natively understands OIDC trusted publishing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the npm publishing GitHub Actions workflow to ensure CI uses an npm version new enough to support OIDC trusted publishing/provenance when running on Node 20 (which ships with npm 10.x).
Changes:
- Install a newer npm globally in the release workflow before running
npm ciand publishing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| node-version: 20 | ||
| cache: npm | ||
| registry-url: https://registry.npmjs.org | ||
| - run: npm install -g npm@latest # trusted publishing requires npm >= 11.5.1 |
There was a problem hiding this comment.
Using npm@latest makes releases non-deterministic and can break unexpectedly when npm 12+ is released (or if latest starts requiring a newer Node than 20). Since the requirement is just >= 11.5.1, pin to a safe range like npm@^11.5.1 (or an exact version) and optionally add a npm --version check to fail fast if the install didn’t take effect.
Suggested change
| - run: npm install -g npm@latest # trusted publishing requires npm >= 11.5.1 | |
| - run: | | |
| npm install -g npm@^11.5.1 # trusted publishing requires npm >= 11.5.1 | |
| npm --version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trusted publishing needs npm ≥11.5.1. Node 20 ships with npm 10.x — upgrade npm at CI start.