feat(mtapot): Cleanup with newer metatomic#262
Merged
HaoZeke merged 2 commits intoTheochemUI:mainfrom Nov 3, 2025
Merged
Conversation
4 tasks
Collaborator
Author
|
Gonna merge this since I need a release before version bumping further anyway. |
HaoZeke
added a commit
that referenced
this pull request
Mar 4, 2026
feat(mtapot): Cleanup with newer `metatomic`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically with
pick_device, which is awesome.However, @PicoCentauri, I was less pleased to see the function return a string, which means more strings stored instead of a
torch::Devicereturn which would be slightly more ergonomic on thecxxside IMO, PR upstream incoming.