Skip to content

Conversation

@chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Nov 5, 2025

fixes #1083

Summary by CodeRabbit

  • Chores
    • Updated release tagging to use semantic versioning format, making releases easier to identify and reference.

Signed-off-by: Rui Chen <rui@chenrui.dev>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 5, 2025

Walkthrough

The release workflow's draft release step is updated to use the discovered semantic version for the tag name instead of the workflow execution ID, changing the tag_name parameter from workflow-${{ github.event.inputs.workflow_id }} to v${{ steps.get_version.outputs.version }}.

Changes

Cohort / File(s) Change Summary
Release Workflow Configuration
.github/workflows/release.yml
Updated tag_name parameter in the "Create Draft Release" step to use semantic version output (v${{ steps.get_version.outputs.version }}) instead of workflow ID reference

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hop, a skip, a tag so fine,
No more workflows muddying the line,
Versions now shine with v-prefix bright,
Release artifacts tagged just right! ✨

Pre-merge checks and finishing touches

✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title directly addresses the change made: updating tag_name to fix release artifact URLs.
Linked Issues check ✅ Passed The change updates tag_name from workflow ID to semantic version, which directly addresses issue #1083's requirement to restore correct release artifact URLs.
Out of Scope Changes check ✅ Passed The PR modifies only the tag_name field in the release workflow step, which is directly scoped to fixing the release artifact URL issue.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9215de7 and bd29452.

📒 Files selected for processing (1)
  • .github/workflows/release.yml (1 hunks)
🔇 Additional comments (2)
.github/workflows/release.yml (2)

86-86: ✅ Correct fix for the release artifact URL issue.

The change from workflow-${{ github.event.inputs.workflow_id }} to v${{ steps.get_version.outputs.version }} directly addresses issue #1083. This restores the semantic version tag format (e.g., v0.4.4) that downstream consumers like Homebrew expect, replacing the incorrect workflow execution ID pattern.

The steps.get_version.outputs.version is reliably populated by the "Get version number" step at lines 30–41, which runs before this step.


30-41: The version extraction regex is correct and handles all version formats used by the project.

Verification confirms the project uses only X.Y.Z semantic versioning format (as documented in build/VERSION-README.md and shown in package.json version "0.4.4"). The regex DeepChat-[0-9]\+\.[0-9]\+\.[0-9]\+ correctly extracts this format, and testing confirmed it gracefully handles pre-release or build metadata if they ever appear (extracting only the base version portion).


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zerob13 zerob13 merged commit 9cd61a7 into ThinkInAIXYZ:dev Nov 6, 2025
2 checks passed
zerob13 added a commit that referenced this pull request Nov 10, 2025
* Merge pull request #1079 from ThinkInAIXYZ/bugfix/refresh-model

fix: custom provider add refresh-model

* fix: add tool call context for better conv (#1081)

* fix: update `tag_name` for release artifact urls (#1084)

Signed-off-by: Rui Chen <rui@chenrui.dev>

* refactor: standardize image block data structure (#1082)

* refactor: standardize image block data structure with backward compatibility

Normalize image_data structure in ThreadPresenter to ensure consistent mimeType handling. Update MessageBlockImage component to support legacy data formats (content as object/string/data URI) while maintaining compatibility with new image_data field.

* fix: properly normalize image data URIs before persistence

Extract base64 content and mime type from data URIs (data:image/jpeg;base64,...) to prevent double-encoding in renderer. This fixes image display errors where data:image/png;base64,data:image/jpeg;base64,... was being constructed.

- Parse data URIs to extract real mime type and base64 content
- Force URL schemes (http://, https://, imgcache://) to deepchat/image-url
- Preserve provided mime types when available
- Fallback to image/png only for raw base64 without metadata

* fix: normalize legacy data URIs in renderer to prevent double-encoding

Handle historical image_data records that may still contain full data:image/...;base64,... URIs. Extract base64 content and mime type before template binding to prevent constructing invalid data:image/png;base64,data:image/png;base64,... URIs.

- Parse data URIs in both new image_data and legacy content formats
- Always provide mimeType fallback for historical records
- Ensure normalized data format before template consumption

* feat: add request trace for llm (#1085)

* feat: add trace support wip

* feat: add trace dialog with monaco

* feat: add i18n for trace dialog

* feat: add config for trace params

* fix: prevent stale previews when messageId changes

* fix: toggle model config refresh (#1086)

* release: 0.4.5

---------

Signed-off-by: Rui Chen <rui@chenrui.dev>
Co-authored-by: Rui Chen <rui@chenrui.dev>
Co-authored-by: 韦伟 <xweimvp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] release artifact url for changed for 0.4.4 release

2 participants