fix: ollama model auto load

[zerob13]

Summary by CodeRabbit

Release Notes

• New Features

  • Added ability to conditionally hide the enable/disable toggle in model configuration settings.

• Bug Fixes

  • Improved local Ollama model state management and synchronization of enabled models list.

[coderabbitai]

Walkthrough

The PR hides enable/disable toggles for local Ollama models in the UI via a new hideEnableToggle prop on the ModelConfigItem component. Simultaneously, the settings store is updated to suppress backend updates for Ollama providers during model status changes while treating local Ollama models as always enabled.

Changes

Cohort / File(s)	Change Summary
UI Component Binding src/renderer/settings/components/OllamaProviderSettingsDetail.vue	Adds hideEnableToggle="true" prop binding to ModelConfigItem component when rendering local models, hiding the enable/disable toggle UI
UI Component Props src/renderer/src/components/settings/ModelConfigItem.vue	Introduces new boolean prop hideEnableToggle (defaults to false) and updates conditional rendering logic to hide enable/disable buttons when this prop is true
Settings Store Logic src/renderer/src/stores/settings.ts	Suppresses backend updates for Ollama providers in updateModelStatus; treats local Ollama models as always enabled; guards enabledModels list updates and re-assigns array references to trigger reactivity

Sequence Diagram

sequenceDiagram
    participant UI as OllamaProviderSettingsDetail
    participant Component as ModelConfigItem
    participant Store as settings.ts
    
    rect rgb(240, 248, 255)
    note over UI,Component: Before: hideEnableToggle not set
    UI->>Component: Render with enabled toggle visible
    Component->>Component: Show enable/disable buttons
    end
    
    rect rgb(240, 250, 240)
    note over UI,Component: After: hideEnableToggle="true"
    UI->>Component: Render with hideEnableToggle=true
    Component->>Component: Hide enable/disable buttons
    end
    
    rect rgb(255, 250, 240)
    note over Store: updateModelStatus for Ollama
    Store->>Store: Return early (skip backend update)
    Store->>Store: Update enabledModels locally
    Store->>Store: Re-assign array to trigger reactivity
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• src/renderer/src/stores/settings.ts may require extra attention due to reactivity-related array re-assignments and early-return logic for Ollama providers that could affect state consistency
• src/renderer/src/components/settings/ModelConfigItem.vue should be reviewed to ensure the conditional rendering logic correctly gates the toggle buttons
• Cross-file consistency: verify that the hideEnableToggle binding in OllamaProviderSettingsDetail aligns with the store's updated model enablement handling

Possibly related PRs

• feat: enable custom model config for Ollama provider #1018: Modifies Ollama provider UI and model enablement logic in OllamaProviderSettingsDetail.vue and related settings store handling
• fix: improve optimistic toggles in settings store #1049: Updates settings store's model enable/disable logic (updateModelStatus and enabledModels handling)
• feat(window): add settings window #996: Modifies the same UI components (ModelConfigItem.vue and OllamaProviderSettingsDetail.vue) with overlapping property/template changes

Suggested labels

codex

Poem

🐰 A toggle hides for local charm,
Where Ollama models keep no harm,
Backend whispers fade away,
Local state runs free today,
Reactivity springs anew!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: ollama model auto load' directly addresses the main objective of the PR - fixing Ollama model auto-loading by suppressing backend updates and managing local model state appropriately.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bugfix/ollama

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 79e9942 and c181930.

📒 Files selected for processing (3)

• src/renderer/settings/components/OllamaProviderSettingsDetail.vue (1 hunks)
• src/renderer/src/components/settings/ModelConfigItem.vue (3 hunks)
• src/renderer/src/stores/settings.ts (3 hunks)

🧰 Additional context used

📓 Path-based instructions (20)

src/renderer/**/*.{vue,ts,js,tsx,jsx}

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

渲染进程代码放在 src/renderer

Files:

• src/renderer/settings/components/OllamaProviderSettingsDetail.vue
• src/renderer/src/components/settings/ModelConfigItem.vue
• src/renderer/src/stores/settings.ts

src/renderer/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,tsx,vue}: Use descriptive variable names with auxiliary verbs (e.g., isLoading, hasError).
Use TypeScript for all code; prefer types over interfaces.
Avoid enums; use const objects instead.
Use arrow functions for methods and computed properties.
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements.

Files:

• src/renderer/settings/components/OllamaProviderSettingsDetail.vue
• src/renderer/src/components/settings/ModelConfigItem.vue
• src/renderer/src/stores/settings.ts

src/renderer/**/*.{vue,ts}

📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)

Implement lazy loading for routes and components.

Files:

• src/renderer/settings/components/OllamaProviderSettingsDetail.vue
• src/renderer/src/components/settings/ModelConfigItem.vue
• src/renderer/src/stores/settings.ts

src/renderer/**/*.{ts,vue}

📄 CodeRabbit inference engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,vue}: Use useFetch and useAsyncData for data fetching.
Implement SEO best practices using Nuxt's useHead and useSeoMeta.

Use Pinia for frontend state management (do not introduce alternative state libraries)

Files:

• src/renderer/settings/components/OllamaProviderSettingsDetail.vue
• src/renderer/src/components/settings/ModelConfigItem.vue
• src/renderer/src/stores/settings.ts

**/*.{ts,tsx,js,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

Use English for all logs and comments

Files:

• src/renderer/settings/components/OllamaProviderSettingsDetail.vue
• src/renderer/src/components/settings/ModelConfigItem.vue
• src/renderer/src/stores/settings.ts

**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

Enable and adhere to strict TypeScript typing (avoid implicit any, prefer precise types)

Use PascalCase for TypeScript types and classes

Files:

• src/renderer/settings/components/OllamaProviderSettingsDetail.vue
• src/renderer/src/components/settings/ModelConfigItem.vue
• src/renderer/src/stores/settings.ts

**/*.{ts,tsx,js,jsx,vue,css,scss,md,json,yml,yaml}

📄 CodeRabbit inference engine (AGENTS.md)

Prettier style: single quotes, no semicolons, print width 100; run pnpm run format

Files:

• src/renderer/settings/components/OllamaProviderSettingsDetail.vue
• src/renderer/src/components/settings/ModelConfigItem.vue
• src/renderer/src/stores/settings.ts

**/*.{ts,tsx,js,jsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,js,jsx,vue}: Use OxLint for JS/TS code; keep lint clean
Use camelCase for variables and functions
Use SCREAMING_SNAKE_CASE for constants

Files:

• src/renderer/settings/components/OllamaProviderSettingsDetail.vue
• src/renderer/src/components/settings/ModelConfigItem.vue
• src/renderer/src/stores/settings.ts

src/renderer/**/*.vue

📄 CodeRabbit inference engine (AGENTS.md)

Name Vue component files in PascalCase (e.g., ChatInput.vue)

Files:

• src/renderer/settings/components/OllamaProviderSettingsDetail.vue
• src/renderer/src/components/settings/ModelConfigItem.vue

src/renderer/src/**/*

📄 CodeRabbit inference engine (.cursor/rules/i18n.mdc)

src/renderer/src/**/*: All user-facing strings must use i18n keys (avoid hardcoded user-visible text in code)
Use the 'vue-i18n' framework for all internationalization in the renderer
Ensure all user-visible text in the renderer uses the translation system

Files:

• src/renderer/src/components/settings/ModelConfigItem.vue
• src/renderer/src/stores/settings.ts

src/renderer/src/**/*.{vue,ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)

src/renderer/src/**/*.{vue,ts,tsx,js,jsx}: Use the Composition API for better code organization and reusability
Implement proper state management with Pinia
Utilize Vue Router for navigation and route management
Leverage Vue's built-in reactivity system for efficient data handling

Files:

• src/renderer/src/components/settings/ModelConfigItem.vue
• src/renderer/src/stores/settings.ts

src/renderer/src/**/*.vue

📄 CodeRabbit inference engine (.cursor/rules/vue-best-practices.mdc)

Use scoped styles to prevent CSS conflicts between components

Files:

• src/renderer/src/components/settings/ModelConfigItem.vue

src/renderer/{src,shell,floating}/**/*.vue

📄 CodeRabbit inference engine (CLAUDE.md)

src/renderer/{src,shell,floating}/**/*.vue: Use Vue 3 Composition API for all components
All user-facing strings must use i18n keys via vue-i18n (no hard-coded UI strings)
Use Tailwind CSS utilities and ensure styles are scoped in Vue components

Files:

• src/renderer/src/components/settings/ModelConfigItem.vue

src/renderer/src/components/**/*

📄 CodeRabbit inference engine (CLAUDE.md)

Organize UI components by feature within src/renderer/src/

Files:

• src/renderer/src/components/settings/ModelConfigItem.vue

src/renderer/src/**

📄 CodeRabbit inference engine (AGENTS.md)

Place Vue 3 app source under src/renderer/src (components, stores, views, i18n, lib)

Files:

• src/renderer/src/components/settings/ModelConfigItem.vue
• src/renderer/src/stores/settings.ts

src/renderer/src/**/*.{vue,ts}

📄 CodeRabbit inference engine (AGENTS.md)

All user-facing strings must use vue-i18n ($t/keys) rather than hardcoded literals

Files:

• src/renderer/src/components/settings/ModelConfigItem.vue
• src/renderer/src/stores/settings.ts

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development-setup.mdc)

**/*.{js,jsx,ts,tsx}: 使用 OxLint 进行代码检查
Log和注释使用英文书写

Files:

• src/renderer/src/stores/settings.ts

src/{main,renderer}/**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/electron-best-practices.mdc)

src/{main,renderer}/**/*.ts: Use context isolation for improved security
Implement proper inter-process communication (IPC) patterns
Optimize application startup time with lazy loading
Implement proper error handling and logging for debugging

Files:

• src/renderer/src/stores/settings.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/error-logging.mdc)

**/*.{ts,tsx}: 始终使用 try-catch 处理可能的错误
提供有意义的错误信息
记录详细的错误日志
优雅降级处理
日志应包含时间戳、日志级别、错误代码、错误描述、堆栈跟踪（如适用）、相关上下文信息
日志级别应包括 ERROR、WARN、INFO、DEBUG
不要吞掉错误
提供用户友好的错误信息
实现错误重试机制
避免记录敏感信息
使用结构化日志
设置适当的日志级别

Files:

• src/renderer/src/stores/settings.ts

src/renderer/src/stores/**/*.{vue,ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/pinia-best-practices.mdc)

src/renderer/src/stores/**/*.{vue,ts,tsx,js,jsx}: Use modules to organize related state and actions
Implement proper state persistence for maintaining data across sessions
Use getters for computed state properties
Utilize actions for side effects and asynchronous operations
Keep the store focused on global state, not component-specific data

Files:

• src/renderer/src/stores/settings.ts

🧠 Learnings (1)

📚 Learning: 2025-07-23T00:45:57.322Z

Learnt from: CR
Repo: ThinkInAIXYZ/deepchat PR: 0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.322Z
Learning: Applies to src/renderer/**/*.{vue} : Use Vue 3 with TypeScript, leveraging defineComponent and PropType.

Applied to files:

• src/renderer/src/components/settings/ModelConfigItem.vue

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build-check (x64)

🔇 Additional comments (5)

src/renderer/src/stores/settings.ts (2)

968-971: Ollama backend skip aligns with auto-enable flow.

The guard cleanly short-circuits backend writes for local Ollama models, matching the new UI behaviour. Looks solid.

---

1507-1573: Local models forced-enabled logic works for reactivity.

Auto-setting the Ollama entries to enabled while pruning empty providers and cloning the array keeps the reactive lists consistent. No issues spotted.

src/renderer/src/components/settings/ModelConfigItem.vue (2)

33-43: Conditional toggle visibility looks good.

The additional guard keeps the enable buttons out of the DOM when suppressed—matches the new prop usage.

---

103-109: Prop defaults read cleanly.

Providing hideEnableToggle with a default preserves existing consumers while making the option opt-in. LGTM.

src/renderer/settings/components/OllamaProviderSettingsDetail.vue (1)

140-153: Binding hide-enable-toggle here makes sense.

Passing the flag for local models lines up with the store changes so the UI no longer exposes an enable toggle. Looks good.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}