Feature/mcp tool improve #635

sqsyli · 2025-07-25T02:50:37Z

Pull Request Description

Is your feature request related to a problem? Please describe.
Support for switching control of MCP tools by session has been added. Previously, the MCP tool was globally enabled, and certain mcp tools could not be selected separately among multiple conversations.

Describe the solution you'd like
Introduced an enabledMcpTools field to the conversation database table. MCP tools are now filtered based on this field, ensuring each conversation only shows its allowed tools.

UI/UX changes for Desktop Application

Platform Compatibility Notes
It was only tested on Windows and no issues were found.

Pull Request Description (中文)

你的功能请求是否与某个问题有关？请描述一下。
新增了对 MCP 工具按会话进行切换控制的支持。之前 MCP 工具是全局启用的，多个对话不能单独选用某些mcp工具。

请描述你希望的解决方案
为 conversation 数据库表添加了 enabledMcpTools 字段。MCP 工具将根据该字段筛选，仅展示当前会话允许使用的工具。

桌面应用程序的 UI/UX 更改

平台兼容性注意事项
仅在 Windows 上测试，未发现问题。

Summary by CodeRabbit

New Features
- Added the ability to enable or disable individual MCP tools for each conversation.
- Updated the conversation settings and UI to allow fine-grained control over which MCP tools are active.
- The enabled MCP tools are now saved, loaded, and synchronized with server status and availability.
- UI now displays and allows toggling of enabled tools, with updated counts and tooltips.
Bug Fixes
- Ensured that conversation tool settings remain consistent with server and tool availability.
Chores
- Database schema updated to support storing enabled MCP tools per conversation.

…ools

coderabbitai · 2025-07-25T02:50:45Z

Walkthrough

This change introduces support for selectively enabling MCP tools in conversations. It adds an enabledMcpTools property to conversation settings, updates the database schema, propagates this setting through presenters and stores, and modifies the UI to allow granular enabling/disabling of MCP tools per conversation and per tool.

Changes

File(s)	Change Summary
`src/main/presenter/llmProviderPresenter/index.ts`, `src/shared/presenter.d.ts`	Added optional `enabledMcpTools` parameter to `startStreamCompletion` method and interface.
`src/main/presenter/mcpPresenter/index.ts`, `src/main/presenter/mcpPresenter/toolManager.ts`	Updated `getAllToolDefinitions` to accept and use an optional tool filter parameter.
`src/main/presenter/sqlitePresenter/tables/conversations.ts`	Added `enabled_mcp_tools` column to schema and logic for create, update, get, and list operations.
`src/main/presenter/threadPresenter/index.ts`	Propagated `enabledMcpTools` through message generation and prompt preparation logic.
`src/renderer/src/components/NewThread.vue`	Passed `enabledMcpTools` to thread creation options.
`src/renderer/src/components/mcpToolsList.vue`	UI and logic for enabling/disabling individual MCP tools; updated enabled tool counting.
`src/renderer/src/stores/chat.ts`	Added `enabledMcpTools` to chat config state.
`src/renderer/src/stores/mcp.ts`	Synced enabled MCP tools in chat config with server/tool status.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI (mcpToolsList.vue/NewThread.vue)
    participant chatStore
    participant mcpStore
    participant ThreadPresenter
    participant LLMProviderPresenter
    participant McpPresenter
    participant ToolManager
    participant DB

    User->>UI (mcpToolsList.vue): Enable/disable tool
    UI->>chatStore: Update enabledMcpTools
    UI->>mcpStore: Sync enabled tools if server status changes

    User->>UI (NewThread.vue): Create new thread
    UI->>chatStore: Read chatConfig (incl. enabledMcpTools)
    UI->>ThreadPresenter: Create/generate thread (with enabledMcpTools)
    ThreadPresenter->>LLMProviderPresenter: startStreamCompletion(..., enabledMcpTools)
    LLMProviderPresenter->>McpPresenter: getAllToolDefinitions(enabledMcpTools)
    McpPresenter->>ToolManager: getAllToolDefinitions(enabledMcpTools)
    ToolManager-->>McpPresenter: Filtered tool definitions
    McpPresenter-->>LLMProviderPresenter: Filtered tool definitions
    LLMProviderPresenter-->>ThreadPresenter: Stream completion
    ThreadPresenter-->>UI: Display response

    ThreadPresenter->>DB: Store/retrieve enabledMcpTools in conversations

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

#594: Modifies MCP tool call permissions and presenter logic, overlapping with changes to LLMProviderPresenter and ThreadPresenter.
#630: Implements and enhances knowledge base features, including enabledMcpTools filtering in the streaming pipeline and UI.
#549: Adds the enabledMcpTools parameter to MCP presenter methods, directly related to the filtering logic introduced here.

Suggested reviewers

deepinfect

Poem

In the warren of code, new tools now appear,
With toggles and switches, their purpose is clear.
Conversations grow smarter, with tools you select,
Each chat now empowered—just the ones you elect!
A hop and a skip, through the UI we bound,
Enabled by choice, new features abound!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 4

🧹 Nitpick comments (3)

src/main/presenter/mcpPresenter/toolManager.ts (1)
211-218: Consider extracting the filtering logic into a helper method.

The filtering logic is duplicated between the cached and fresh data paths. This could lead to maintenance issues if the filtering logic needs to be updated.

Consider extracting the filtering logic into a private helper method:
private filterToolsByEnabled(tools: MCPToolDefinition[], enabledTools: string[]): MCPToolDefinition[] {
  const enabledSet = new Set(enabledTools)
  return tools.filter((toolDef) => {
    const finalName = toolDef.function.name
    const originalName = this.toolNameToTargetMap?.get(finalName)?.originalName || finalName
    return enabledSet.has(finalName) || enabledSet.has(originalName)
  })
}
Then use it in both places:
-    if (enabledTools && enabledTools.length > 0) {
-      const enabledSet = new Set(enabledTools)
-      return this.cachedToolDefinitions.filter((toolDef) => {
-        const finalName = toolDef.function.name
-        const originalName = this.toolNameToTargetMap?.get(finalName)?.originalName || finalName
-        return enabledSet.has(finalName) || enabledSet.has(originalName)
-      })
-    }
+    if (enabledTools && enabledTools.length > 0) {
+      return this.filterToolsByEnabled(this.cachedToolDefinitions, enabledTools)
+    }
src/renderer/src/components/mcpToolsList.vue (1)
35-47: Helper functions are well-implemented.

The tool count functions correctly filter based on enabled tools with proper null safety.

The getTotalEnabledToolCount function could be slightly more concise:
 const getTotalEnabledToolCount = () => {
   const enabledMcpTools = chatStore.chatConfig.enabledMcpTools || []
-  const filterList = mcpStore.tools.filter((item) => enabledMcpTools.includes(item.function.name))
-  return filterList.length
+  return mcpStore.tools.filter((item) => enabledMcpTools.includes(item.function.name)).length
 }
src/main/presenter/sqlitePresenter/tables/conversations.ts (1)
23-30: Change comment to English to comply with coding guidelines.

The function implementation is solid with proper error handling and type safety. However, the comment should be in English per the coding guidelines for TypeScript files.
-// 解析 JSON 字段
+// Parse JSON field with fallback default value

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 633997a and 34ddb74.

📒 Files selected for processing (10)

src/main/presenter/llmProviderPresenter/index.ts (3 hunks)
src/main/presenter/mcpPresenter/index.ts (1 hunks)
src/main/presenter/mcpPresenter/toolManager.ts (2 hunks)
src/main/presenter/sqlitePresenter/tables/conversations.ts (9 hunks)
src/main/presenter/threadPresenter/index.ts (7 hunks)
src/renderer/src/components/NewThread.vue (1 hunks)
src/renderer/src/components/mcpToolsList.vue (4 hunks)
src/renderer/src/stores/chat.ts (1 hunks)
src/renderer/src/stores/mcp.ts (4 hunks)
src/shared/presenter.d.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (21)

**/*.{ts,tsx,js,jsx,vue}

📄 CodeRabbit Inference Engine (CLAUDE.md)

Use English for logs and comments

Files:

src/renderer/src/components/NewThread.vue
src/renderer/src/stores/chat.ts
src/shared/presenter.d.ts
src/main/presenter/threadPresenter/index.ts
src/main/presenter/mcpPresenter/toolManager.ts
src/main/presenter/mcpPresenter/index.ts
src/main/presenter/llmProviderPresenter/index.ts
src/renderer/src/stores/mcp.ts
src/renderer/src/components/mcpToolsList.vue
src/main/presenter/sqlitePresenter/tables/conversations.ts

src/renderer/src/**/*.vue

📄 CodeRabbit Inference Engine (CLAUDE.md)

src/renderer/src/**/*.vue: Use Composition API for all Vue 3 components
Use Tailwind CSS with scoped styles for styling
Organize components by feature in src/renderer/src/
Follow existing component patterns in src/renderer/src/ when creating new UI components
Use Composition API with proper TypeScript typing for new UI components
Implement responsive design with Tailwind CSS for new UI components
Add proper error handling and loading states for new UI components

Use scoped styles to prevent CSS conflicts between components

Files:

src/renderer/src/components/NewThread.vue
src/renderer/src/components/mcpToolsList.vue

src/renderer/src/**/*.{ts,tsx,vue}

📄 CodeRabbit Inference Engine (CLAUDE.md)

src/renderer/src/**/*.{ts,tsx,vue}: Use Pinia for frontend state management
Renderer to Main: Use usePresenter.ts composable for direct presenter method calls

Files:

src/renderer/src/components/NewThread.vue
src/renderer/src/stores/chat.ts
src/renderer/src/stores/mcp.ts
src/renderer/src/components/mcpToolsList.vue

src/renderer/src/**/*

📄 CodeRabbit Inference Engine (.cursor/rules/i18n.mdc)

src/renderer/src/**/*: All user-facing strings must use i18n keys (avoid hardcoded user-visible text in code)
Use the 'vue-i18n' framework for all internationalization in the renderer
Ensure all user-visible text in the renderer uses the translation system

Files:

src/renderer/src/components/NewThread.vue
src/renderer/src/stores/chat.ts
src/renderer/src/stores/mcp.ts
src/renderer/src/components/mcpToolsList.vue

src/renderer/**/*.{vue,ts,js,tsx,jsx}

📄 CodeRabbit Inference Engine (.cursor/rules/project-structure.mdc)

渲染进程代码放在 src/renderer

Files:

src/renderer/src/components/NewThread.vue
src/renderer/src/stores/chat.ts
src/renderer/src/stores/mcp.ts
src/renderer/src/components/mcpToolsList.vue

src/renderer/src/**/*.{vue,ts,tsx,js,jsx}

📄 CodeRabbit Inference Engine (.cursor/rules/vue-best-practices.mdc)

src/renderer/src/**/*.{vue,ts,tsx,js,jsx}: Use the Composition API for better code organization and reusability
Implement proper state management with Pinia
Utilize Vue Router for navigation and route management
Leverage Vue's built-in reactivity system for efficient data handling

Files:

src/renderer/src/components/NewThread.vue
src/renderer/src/stores/chat.ts
src/renderer/src/stores/mcp.ts
src/renderer/src/components/mcpToolsList.vue

src/renderer/**/*.{ts,tsx,vue}

📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,tsx,vue}: Use descriptive variable names with auxiliary verbs (e.g., isLoading, hasError).
Use TypeScript for all code; prefer types over interfaces.
Avoid enums; use const objects instead.
Use arrow functions for methods and computed properties.
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements.

Files:

src/renderer/src/components/NewThread.vue
src/renderer/src/stores/chat.ts
src/renderer/src/stores/mcp.ts
src/renderer/src/components/mcpToolsList.vue

src/renderer/**/*.{vue,ts}

📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)

Implement lazy loading for routes and components.

Files:

src/renderer/src/components/NewThread.vue
src/renderer/src/stores/chat.ts
src/renderer/src/stores/mcp.ts
src/renderer/src/components/mcpToolsList.vue

src/renderer/**/*.{ts,vue}

📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)

src/renderer/**/*.{ts,vue}: Use useFetch and useAsyncData for data fetching.
Implement SEO best practices using Nuxt's useHead and useSeoMeta.

Files:

src/renderer/src/components/NewThread.vue
src/renderer/src/stores/chat.ts
src/renderer/src/stores/mcp.ts
src/renderer/src/components/mcpToolsList.vue

**/*.{ts,tsx}

📄 CodeRabbit Inference Engine (CLAUDE.md)

Strict type checking enabled for TypeScript

**/*.{ts,tsx}: 始终使用 try-catch 处理可能的错误
提供有意义的错误信息
记录详细的错误日志
优雅降级处理
日志应包含时间戳、日志级别、错误代码、错误描述、堆栈跟踪（如适用）、相关上下文信息
日志级别应包括 ERROR、WARN、INFO、DEBUG
不要吞掉错误
提供用户友好的错误信息
实现错误重试机制
避免记录敏感信息
使用结构化日志
设置适当的日志级别

Files:

src/renderer/src/stores/chat.ts
src/shared/presenter.d.ts
src/main/presenter/threadPresenter/index.ts
src/main/presenter/mcpPresenter/toolManager.ts
src/main/presenter/mcpPresenter/index.ts
src/main/presenter/llmProviderPresenter/index.ts
src/renderer/src/stores/mcp.ts
src/main/presenter/sqlitePresenter/tables/conversations.ts

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit Inference Engine (.cursor/rules/development-setup.mdc)

**/*.{js,jsx,ts,tsx}: 使用 OxLint 进行代码检查
Log和注释使用英文书写

Files:

src/renderer/src/stores/chat.ts
src/shared/presenter.d.ts
src/main/presenter/threadPresenter/index.ts
src/main/presenter/mcpPresenter/toolManager.ts
src/main/presenter/mcpPresenter/index.ts
src/main/presenter/llmProviderPresenter/index.ts
src/renderer/src/stores/mcp.ts
src/main/presenter/sqlitePresenter/tables/conversations.ts

src/{main,renderer}/**/*.ts

📄 CodeRabbit Inference Engine (.cursor/rules/electron-best-practices.mdc)

src/{main,renderer}/**/*.ts: Use context isolation for improved security
Implement proper inter-process communication (IPC) patterns
Optimize application startup time with lazy loading
Implement proper error handling and logging for debugging

Files:

src/renderer/src/stores/chat.ts
src/main/presenter/threadPresenter/index.ts
src/main/presenter/mcpPresenter/toolManager.ts
src/main/presenter/mcpPresenter/index.ts
src/main/presenter/llmProviderPresenter/index.ts
src/renderer/src/stores/mcp.ts
src/main/presenter/sqlitePresenter/tables/conversations.ts

src/renderer/src/stores/**/*.{vue,ts,tsx,js,jsx}

📄 CodeRabbit Inference Engine (.cursor/rules/pinia-best-practices.mdc)

src/renderer/src/stores/**/*.{vue,ts,tsx,js,jsx}: Use modules to organize related state and actions
Implement proper state persistence for maintaining data across sessions
Use getters for computed state properties
Utilize actions for side effects and asynchronous operations
Keep the store focused on global state, not component-specific data

Files:

src/renderer/src/stores/chat.ts
src/renderer/src/stores/mcp.ts

src/shared/**/*.ts

📄 CodeRabbit Inference Engine (CLAUDE.md)

Shared types in src/shared/

Files:

src/shared/presenter.d.ts

src/shared/*.d.ts

📄 CodeRabbit Inference Engine (.cursor/rules/electron-best-practices.mdc)

The shared/*.d.ts files are used to define the types of objects exposed by the main process to the renderer process

Files:

src/shared/presenter.d.ts

src/shared/**/*.{ts,tsx,d.ts}

📄 CodeRabbit Inference Engine (.cursor/rules/project-structure.mdc)

共享类型定义放在 shared 目录

Files:

src/shared/presenter.d.ts

src/main/**/*.ts

📄 CodeRabbit Inference Engine (CLAUDE.md)

Main to Renderer: Use EventBus to broadcast events via mainWindow.webContents.send()

Use Electron's built-in APIs for file system and native dialogs

Files:

src/main/presenter/threadPresenter/index.ts
src/main/presenter/mcpPresenter/toolManager.ts
src/main/presenter/mcpPresenter/index.ts
src/main/presenter/llmProviderPresenter/index.ts
src/main/presenter/sqlitePresenter/tables/conversations.ts

src/main/presenter/**/*.ts

📄 CodeRabbit Inference Engine (CLAUDE.md)

One presenter per functional domain

Files:

src/main/presenter/threadPresenter/index.ts
src/main/presenter/mcpPresenter/toolManager.ts
src/main/presenter/mcpPresenter/index.ts
src/main/presenter/llmProviderPresenter/index.ts
src/main/presenter/sqlitePresenter/tables/conversations.ts

src/main/**/*.{ts,js,tsx,jsx}

📄 CodeRabbit Inference Engine (.cursor/rules/project-structure.mdc)

主进程代码放在 src/main

Files:

src/main/presenter/threadPresenter/index.ts
src/main/presenter/mcpPresenter/toolManager.ts
src/main/presenter/mcpPresenter/index.ts
src/main/presenter/llmProviderPresenter/index.ts
src/main/presenter/sqlitePresenter/tables/conversations.ts

src/main/presenter/mcpPresenter/index.ts

📄 CodeRabbit Inference Engine (CLAUDE.md)

Register new MCP tool in mcpPresenter/index.ts

Files:

src/main/presenter/mcpPresenter/index.ts

src/main/presenter/llmProviderPresenter/index.ts

📄 CodeRabbit Inference Engine (.cursor/rules/llm-agent-loop.mdc)

src/main/presenter/llmProviderPresenter/index.ts: src/main/presenter/llmProviderPresenter/index.ts should manage the overall Agent loop, conversation history, tool execution via McpPresenter, and frontend communication via eventBus.
The main Agent loop in llmProviderPresenter/index.ts should handle multi-round LLM calls and tool usage, maintaining conversation state and controlling the loop with needContinueConversation and toolCallCount.
The main Agent loop should send standardized STREAM_EVENTS (RESPONSE, END, ERROR) to the frontend via eventBus.
The main Agent loop should buffer text content, handle tool call events, format tool results for the next LLM call, and manage conversation continuation logic.

Files:

src/main/presenter/llmProviderPresenter/index.ts

🧠 Learnings (11)

📓 Common learnings

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/mcpPresenter/index.ts : Register new MCP tool in mcpPresenter/index.ts

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/mcpPresenter/inMemoryServers/*.ts : Implement new MCP tool in src/main/presenter/mcpPresenter/inMemoryServers/ when adding a new MCP tool

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : When a provider supports native function calling, MCP tools must be converted to the provider's format (e.g., using `convertToProviderTools`) and included in the API request.

src/renderer/src/components/NewThread.vue (6)

Learnt from: neoragex2002
PR: #550
File: src/renderer/src/stores/chat.ts:1011-1035
Timestamp: 2025-06-21T15:49:17.044Z
Learning: In src/renderer/src/stores/chat.ts, the user prefers to keep both text and content properties in the handleMeetingInstruction function's sendMessage call, even though they are redundant, rather than removing the content property.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/mcpPresenter/index.ts : Register new MCP tool in mcpPresenter/index.ts

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:47:28.788Z
Learning: Applies to src/renderer/src/**/*.{vue,ts,tsx,js,jsx} : Leverage Vue's built-in reactivity system for efficient data handling

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/mcpPresenter/inMemoryServers/*.ts : Implement new MCP tool in src/main/presenter/mcpPresenter/inMemoryServers/ when adding a new MCP tool

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{vue} : Use composition API and declarative programming patterns; avoid options API.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : When a provider supports native function calling, MCP tools must be converted to the provider's format (e.g., using convertToProviderTools) and included in the API request.

src/renderer/src/stores/chat.ts (6)

Learnt from: neoragex2002
PR: #550
File: src/renderer/src/stores/chat.ts:1011-1035
Timestamp: 2025-06-21T15:49:17.044Z
Learning: In src/renderer/src/stores/chat.ts, the user prefers to keep both text and content properties in the handleMeetingInstruction function's sendMessage call, even though they are redundant, rather than removing the content property.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/mcpPresenter/index.ts : Register new MCP tool in mcpPresenter/index.ts

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/mcpPresenter/inMemoryServers/*.ts : Implement new MCP tool in src/main/presenter/mcpPresenter/inMemoryServers/ when adding a new MCP tool

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/stores/**/*.ts : Use Pinia for state management.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : When a provider supports native function calling, MCP tools must be converted to the provider's format (e.g., using convertToProviderTools) and included in the API request.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/pinia-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:47:03.467Z
Learning: Applies to src/renderer/src/stores/**/*.{vue,ts,tsx,js,jsx} : Implement proper state persistence for maintaining data across sessions

src/shared/presenter.d.ts (13)

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/index.ts : src/main/presenter/llmProviderPresenter/index.ts should manage the overall Agent loop, conversation history, tool execution via McpPresenter, and frontend communication via eventBus.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : When a provider supports native function calling, MCP tools must be converted to the provider's format (e.g., using convertToProviderTools) and included in the API request.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Implement coreStream method following standardized event interface in LLM provider files

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : The coreStream method in each Provider must perform a single streaming API request per conversation round and must not contain multi-round tool call loop logic.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Provider files should implement helper methods such as formatMessages, convertToProviderTools, parseFunctionCalls, and prepareFunctionCallPrompt as needed for provider-specific logic.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/index.ts : The main Agent loop in llmProviderPresenter/index.ts should handle multi-round LLM calls and tool usage, maintaining conversation state and controlling the loop with needContinueConversation and toolCallCount.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Each file in src/main/presenter/llmProviderPresenter/providers/*.ts should handle interaction with a specific LLM API, including request/response formatting, tool definition conversion, native/non-native tool call management, and standardizing output streams to a common event format.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Provider implementations should yield tool call events (tool_call_start, tool_call_chunk, tool_call_end) in the standardized format.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/mcpPresenter/index.ts : Register new MCP tool in mcpPresenter/index.ts

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/index.ts : The main Agent loop should buffer text content, handle tool call events, format tool results for the next LLM call, and manage conversation continuation logic.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Provider implementations should yield events asynchronously using the async generator pattern.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Provider implementations should aggregate and yield usage events as part of the standardized stream.

Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/index.ts : The main Agent loop should send standardized STREAM_EVENTS (RESPONSE, END, ERROR) to the frontend via eventBus.

src/main/presenter/threadPresenter/index.ts (14)