-
Notifications
You must be signed in to change notification settings - Fork 625
refactor: better translate #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0603274
adbc998
94d9c32
7dc5e92
f80fee8
e4e5bc9
663730f
7ae9e53
10dd25b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -37,7 +37,7 @@ | |||||
| "required": "Required", | ||||||
| "characters": "Characters", | ||||||
| "fileManagement": "File Management", | ||||||
| "uploadFromDevice": "Upload from Your Device", | ||||||
| "uploadFromDevice": "Upload from device", | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainConfirm style guide (Title Case vs Sentence case) If the project is moving to sentence case for action labels, keep as-is and plan a bulk pass for consistency. 🏁 Script executed: #!/bin/bash
# Quick scan of this file to see casing of top-level labels
sed -n '2,70p' src/renderer/src/i18n/en-US/promptSetting.json | rg -n '": "([A-Z][a-z]+ [A-Z][a-z]+|[A-Z][a-z]+)"' -oLength of output: 657 Inconsistent Casing in promptSetting.json A quick scan shows most action labels in src/renderer/src/i18n/en-US/promptSetting.json use Title Case (e.g. “Add Prompt”, “Edit Prompt”), but the entry at line 40: • is in sentence case. Please choose one convention and apply it consistently:
📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| "uploadFromDeviceDesc": "Supports text, documents, CSV, and more.", | ||||||
| "uploadedFiles": "Uploaded Files", | ||||||
| "noFiles": "No files", | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Terminology shift to “Access” is consistent; placeholders intact
Labels read well and descriptions consistently use “from” with '{toolName}' and '{serverName}'.
Check that all locales keep both placeholders present in the permission descriptions:
🏁 Script executed:
Length of output: 73
🏁 Script executed:
Length of output: 14158
Fix placeholder casing in ko-KR locale
We’ve verified that all other locales include both
{toolName}and{serverName}correctly, but inko-KR/components.jsonthe placeholders are mis-cased ({toolname}/{servername}), which will break interpolation.• File:
src/renderer/src/i18n/ko-KR/components.json– description.read
– description.write
– description.all
Suggested diff for each key:
📝 Committable suggestion
🤖 Prompt for AI Agents