Skip to content

feat: add support for zero temperature #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zerob13 merged 1 commit into from
Sep 19, 2025
Merged

feat: add support for zero temperature #920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/main/presenter/llmProviderPresenter/providers/anthropicProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,7 @@ export class AnthropicProvider extends BaseLLMProvider {
requestParams = {
model: modelId,
max_tokens: maxTokens || 1024,
temperature: temperature || 0.7,
temperature: temperature ?? 0.7,
system: "You are Claude Code, Anthropic's official CLI for Claude.",
messages: oauthMessages
}
Expand All @@ -794,7 +794,7 @@ export class AnthropicProvider extends BaseLLMProvider {
requestParams = {
model: modelId,
max_tokens: maxTokens || 1024,
temperature: temperature || 0.7,
temperature: temperature ?? 0.7,
messages: formattedMessages.messages
}

Expand Down Expand Up @@ -898,7 +898,7 @@ ${text}
requestParams = {
model: modelId,
max_tokens: maxTokens || 1024,
temperature: temperature || 0.7,
temperature: temperature ?? 0.7,
system: "You are Claude Code, Anthropic's official CLI for Claude.",
messages: [{ role: 'user', content: finalPrompt }]
}
Expand All @@ -909,7 +909,7 @@ ${text}
requestParams = {
model: modelId,
max_tokens: maxTokens || 1024,
temperature: temperature || 0.7,
temperature: temperature ?? 0.7,
messages: [{ role: 'user' as const, content: [{ type: 'text' as const, text: prompt }] }]
}

Expand Down Expand Up @@ -967,7 +967,7 @@ ${context}
requestParams = {
model: modelId,
max_tokens: maxTokens || 1024,
temperature: temperature || 0.7,
temperature: temperature ?? 0.7,
system: "You are Claude Code, Anthropic's official CLI for Claude.",
messages: [{ role: 'user', content: finalPrompt }]
}
Expand All @@ -978,7 +978,7 @@ ${context}
requestParams = {
model: modelId,
max_tokens: maxTokens || 1024,
temperature: temperature || 0.7,
temperature: temperature ?? 0.7,
messages: [{ role: 'user' as const, content: [{ type: 'text' as const, text: prompt }] }]
}

Expand Down Expand Up @@ -1042,7 +1042,7 @@ ${context}
const streamParams = {
model: modelId,
max_tokens: maxTokens || 1024,
temperature: temperature || 0.7,
temperature: temperature ?? 0.7,
messages: formattedMessagesObject.messages,
stream: true
} as Anthropic.Messages.MessageCreateParamsStreaming
Expand Down Expand Up @@ -1266,7 +1266,7 @@ ${context}
const streamParams: any = {
model: modelId,
max_tokens: maxTokens || 1024,
temperature: temperature || 0.7,
temperature: temperature ?? 0.7,
system: "You are Claude Code, Anthropic's official CLI for Claude.",
messages: oauthMessages,
stream: true
Expand Down
2 changes: 1 addition & 1 deletion src/main/presenter/llmProviderPresenter/providers/awsBedrockProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ ${text}
const payload = {
anthropic_version: 'bedrock-2023-05-31',
max_tokens: maxTokens || 1024,
temperature: temperature || 0.7,
temperature: temperature ?? 0.7,
// system: formattedMessagesObject.system,
messages: formattedMessagesObject.messages,
thinking: undefined as any,
Expand Down
2 changes: 1 addition & 1 deletion src/main/presenter/llmProviderPresenter/providers/geminiProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ export class GeminiProvider extends BaseLLMProvider {

// 创建 GenerateContentConfig
const generateContentConfig: GenerateContentConfig = this.getGenerateContentConfig(
temperature || 0.7,
temperature ?? 0.7,
maxTokens,
modelId,
false // completions 方法中不处理 reasoning
Expand Down
4 changes: 2 additions & 2 deletions src/main/presenter/llmProviderPresenter/providers/githubCopilotProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ export class GithubCopilotProvider extends BaseLLMProvider {
messages: formattedMessages,
max_tokens: maxTokens || 4096,
stream: true,
temperature: temperature || 0.7
temperature: temperature ?? 0.7
}

// Add tools when available
Expand Down Expand Up @@ -506,7 +506,7 @@ export class GithubCopilotProvider extends BaseLLMProvider {
messages: formattedMessages,
max_tokens: maxTokens || 4096,
stream: false,
temperature: temperature || 0.7
temperature: temperature ?? 0.7
}

const headers: Record<string, string> = {
Expand Down
10 changes: 5 additions & 5 deletions src/main/presenter/llmProviderPresenter/providers/ollamaProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export class OllamaProvider extends BaseLLMProvider {
model: modelId,
messages: this.formatMessages(messages),
options: {
temperature: temperature || 0.7,
temperature: temperature ?? 0.7,
num_predict: maxTokens
}
})
Expand Down Expand Up @@ -226,7 +226,7 @@ export class OllamaProvider extends BaseLLMProvider {
model: modelId,
prompt: prompt,
options: {
temperature: temperature || 0.5,
temperature: temperature ?? 0.5,
num_predict: maxTokens
}
})
Expand All @@ -252,7 +252,7 @@ export class OllamaProvider extends BaseLLMProvider {
model: modelId,
prompt: prompt,
options: {
temperature: temperature || 0.7,
temperature: temperature ?? 0.7,
num_predict: maxTokens
}
})
Expand Down Expand Up @@ -280,7 +280,7 @@ export class OllamaProvider extends BaseLLMProvider {
model: modelId,
prompt: prompt,
options: {
temperature: temperature || 0.8,
temperature: temperature ?? 0.8,
num_predict: maxTokens || 200
}
})
Expand Down Expand Up @@ -499,7 +499,7 @@ export class OllamaProvider extends BaseLLMProvider {
model: modelId,
messages: processedMessages,
options: {
temperature: temperature || 0.7,
temperature: temperature ?? 0.7,
num_predict: maxTokens
},
stream: true as const,
Expand Down
4 changes: 2 additions & 2 deletions src/main/presenter/mcpPresenter/inMemoryServers/imageServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export class ImageServer {
this.provider,
messages,
this.model,
modelConfig?.temperature || 0.6,
modelConfig?.temperature ?? 0.6,
modelConfig?.maxTokens || 1000
)
console.log(`Model response received: ${response}`)
Expand Down Expand Up @@ -171,7 +171,7 @@ export class ImageServer {
this.provider,
messages,
this.model,
modelConfig?.temperature || 0.6,
modelConfig?.temperature ?? 0.6,
modelConfig?.maxTokens || 1000
)
console.log(`OCR text received: ${ocrText}`)
Expand Down
2 changes: 1 addition & 1 deletion src/main/presenter/sqlitePresenter/tables/conversations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export class ConversationsTable extends BaseTable {
now,
now,
settings.systemPrompt || '',
settings.temperature || 0.7,
settings.temperature ?? 0.7,
settings.contextLength || 4000,
settings.maxTokens || 2000,
settings.providerId || 'openai',
Expand Down
2 changes: 1 addition & 1 deletion src/main/presenter/threadPresenter/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,7 +1046,7 @@ export class ThreadPresenter implements IThreadPresenter {
if (settings.maxTokens) {
mergedSettings.maxTokens = settings.maxTokens
}
if (settings.temperature) {
if (settings.temperature !== undefined && settings.temperature !== null) {
mergedSettings.temperature = settings.temperature
}
if (settings.contextLength) {
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/src/components/ChatConfig.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ const qwen3ThinkingBudgetError = computed(() => {
</div>
<span class="text-xs text-muted-foreground">{{ temperatureValue[0] }}</span>
</div>
<Slider v-model="temperatureValue" :min="0.1" :max="1.5" :step="0.1" />
<Slider v-model="temperatureValue" :min="0" :max="1.5" :step="0.1" />
</div>

<!-- Context Length -->
Expand Down
6 changes: 4 additions & 2 deletions src/renderer/src/components/TitleView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,10 @@ const loadModelConfig = async () => {
} else if (maxTokens.value < 1024) {
maxTokens.value = 1024
}
// reset to default temperature
temperature.value = config.temperature ?? 0.6
// Do not override user-set temperature; only set if unset
if (temperature.value === undefined || temperature.value === null) {
temperature.value = config.temperature ?? 0.6
}

if (config.thinkingBudget !== undefined) {
if (thinkingBudget.value === undefined) {
Expand Down