Skip to content

Conversation

@zerob13
Copy link
Collaborator

@zerob13 zerob13 commented Sep 28, 2025

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 28, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

192 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/upgrade-tw4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zerob13
Copy link
Collaborator Author

zerob13 commented Sep 29, 2025

@codex review this pr

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

<TooltipProvider>
<Tooltip :delay-duration="200">
<TooltipTrigger as-child>
<Switch
:checked="isFastGptMcpEnabled"
:disabled="!mcpStore.mcpEnabled"
@update:checked="toggleFastGptMcpServer"
/>
</TooltipTrigger>
<TooltipContent v-if="!mcpStore.mcpEnabled">
<p>{{ t('settings.mcp.enableToAccess') }}</p>
</TooltipContent>
</Tooltip>
</TooltipProvider>
<Button
variant="outline"
size="sm"
class="flex items-center gap-1"
@click="toggleFastGptConfigPanel"
>
<Icon
:icon="isFastGptConfigPanelOpen ? 'lucide:chevron-up' : 'lucide:chevron-down'"
class="w-4 h-4"
/>
{{ isFastGptConfigPanelOpen ? t('common.collapse') : t('common.expand') }}
</Button>
</div>
</div>
<!-- FastGPT配置面板 -->
<Collapsible v-model:open="isFastGptConfigPanelOpen">
<CollapsibleContent>
<div class="p-4 border-t space-y-4">
<!-- 已添加的配置列表 -->
<div v-if="fastGptConfigs.length > 0" class="space-y-3">
<div
v-for="(config, index) in fastGptConfigs"
:key="index"
class="p-3 border rounded-md relative"
>
<div class="absolute top-2 right-2 flex gap-2">
<Switch
:checked="config.enabled === true"
size="sm"
@update:checked="toggleConfigEnabled(index, $event)"

[P1] Update Switch bindings to new modelValue API

The migration swaps in the reka-ui switch (see the new imports), which only accepts modelValue/update:modelValue for two-way binding. The template here still uses the old :checked and @update:checked props, so toggling FastGPT’s MCP switch or individual config switches will no longer emit updates and the UI state will desynchronize. The same pattern appears in other files (e.g. PromptSetting.vue, mcpServerForm.vue). These bindings need to be changed to :model-value and @update:model-value to keep switches working.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@zerob13 zerob13 marked this pull request as ready for review September 29, 2025 10:23
@zerob13
Copy link
Collaborator Author

zerob13 commented Sep 29, 2025

@codex review this pr

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@zerob13
Copy link
Collaborator Author

zerob13 commented Sep 29, 2025

  • [] thinking block can't be collapsed
  • [] After closing the code block, it should not be possible to click to expand it; otherwise, calculations may be incorrect.

@zerob13 zerob13 changed the title wip: migration to tailwind v4 refactor: migration to tailwind v4 Sep 29, 2025
@zerob13 zerob13 merged commit 63ac458 into dev Sep 29, 2025
2 checks passed
@zerob13 zerob13 deleted the chore/upgrade-tw4 branch November 23, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants