-
Notifications
You must be signed in to change notification settings - Fork 625
refactor: migration to tailwind v4 #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 192 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
deepchat/src/renderer/src/components/settings/FastGptKnowledgeSettings.vue
Lines 15 to 59 in b12cd1b
| <TooltipProvider> | |
| <Tooltip :delay-duration="200"> | |
| <TooltipTrigger as-child> | |
| <Switch | |
| :checked="isFastGptMcpEnabled" | |
| :disabled="!mcpStore.mcpEnabled" | |
| @update:checked="toggleFastGptMcpServer" | |
| /> | |
| </TooltipTrigger> | |
| <TooltipContent v-if="!mcpStore.mcpEnabled"> | |
| <p>{{ t('settings.mcp.enableToAccess') }}</p> | |
| </TooltipContent> | |
| </Tooltip> | |
| </TooltipProvider> | |
| <Button | |
| variant="outline" | |
| size="sm" | |
| class="flex items-center gap-1" | |
| @click="toggleFastGptConfigPanel" | |
| > | |
| <Icon | |
| :icon="isFastGptConfigPanelOpen ? 'lucide:chevron-up' : 'lucide:chevron-down'" | |
| class="w-4 h-4" | |
| /> | |
| {{ isFastGptConfigPanelOpen ? t('common.collapse') : t('common.expand') }} | |
| </Button> | |
| </div> | |
| </div> | |
| <!-- FastGPT配置面板 --> | |
| <Collapsible v-model:open="isFastGptConfigPanelOpen"> | |
| <CollapsibleContent> | |
| <div class="p-4 border-t space-y-4"> | |
| <!-- 已添加的配置列表 --> | |
| <div v-if="fastGptConfigs.length > 0" class="space-y-3"> | |
| <div | |
| v-for="(config, index) in fastGptConfigs" | |
| :key="index" | |
| class="p-3 border rounded-md relative" | |
| > | |
| <div class="absolute top-2 right-2 flex gap-2"> | |
| <Switch | |
| :checked="config.enabled === true" | |
| size="sm" | |
| @update:checked="toggleConfigEnabled(index, $event)" |
[P1] Update Switch bindings to new modelValue API
The migration swaps in the reka-ui switch (see the new imports), which only accepts modelValue/update:modelValue for two-way binding. The template here still uses the old :checked and @update:checked props, so toggling FastGPT’s MCP switch or individual config switches will no longer emit updates and the UI state will desynchronize. The same pattern appears in other files (e.g. PromptSetting.vue, mcpServerForm.vue). These bindings need to be changed to :model-value and @update:model-value to keep switches working.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
|
@codex review this pr |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting |
|
No description provided.