Fix pane widths not resetting when switching tabs across view modes#68
Merged
ThisIs-Developer merged 1 commit intoThisIs-Developer:mainfrom Apr 8, 2026
Merged
Conversation
When switching between tabs with different view modes (e.g., split and preview), the inline flex styles from split mode were not being cleared. This happened because restoreViewMode() sets currentViewMode to null before calling setViewMode(), causing the previousMode === 'split' check to always fail. Changed the condition to always reset pane widths when entering a non-split mode, regardless of the previous mode value.
|
Someone is attempting to deploy a commit to the ThisIs-Developer Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
|
@jhrepo Thank you for your contribution, appreciate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Expected: Full-width Preview mode.
Actual: Preview renders at 50% width, leaving the right half empty.
Root Cause
restoreViewMode()setscurrentViewMode = nullbefore callingsetViewMode(), sopreviousModeis alwaysnullinsidesetViewMode(). ThepreviousMode === 'split'check never passes,resetPaneWidths()is never called, and the inline flex stylesfrom Split mode persist and override the CSS.
Fix
Changed
else if (previousMode === 'split')toelseso inline flex styles are always cleared when entering a non-split mode.if (mode === 'split') { applyPaneWidths(); - } else if (previousMode === 'split') { + } else { resetPaneWidths(); } resetPaneWidths() only sets style.flex = '', which is a no-op when no inline styles exist. No side effects for other mode transitions.