551 adding vc less parsing to parsemembers#641
Merged
Conversation
Added vcOptions parameter to afkCheck class, stores templateVcOptions from afkTemplate on the raid itself
Added in vcOptions, leader, and afkTemplate name to stored afk checks, discovered that not all information is being stored
first attempt at making o3 parses worth 1.5 points in parsecurrentweek. still work in progress
Added in support for vc-less parsing, still work in progress Currently google vision api calls are removed in favor of proxy variables for testing
Added json to store templates worth 1.5 parses Updated quotas.json and currentweekInfo to add o3parse type to halls and testing halls Updated parsemembers to log quota value based on template
Fixed raid filtering Fixed bugs in vc-less parsing
Bring vibot to version 8.8.1
4 tasks
fix for undefined users in raid selection modal
jiajieh01
added
Lost Halls
Ragviswa
suggested changes
Jan 25, 2024
Contributor
Ragviswa
left a comment
Ragviswa
left a comment
There was a problem hiding this comment.
Hey Trodaire. You did great with coming back quickly with VC-less Parsing and O3 Parsing! Thanks for that.
I've only listed a couple functional doubts/comments I had, rather than go in-depth into every aspect of the code. Feel free to ask me any questions about any of them and if you feel any comments contain incorrect judgement, then you can bring that up.
Anyone else is free to leave a review as well. Very well I may have missed things! Overall I'm pleased with your progress :)
Add leader and early slot members to member list and add leader to count logged runs
Updated code based on suggestions in PR Cleaned up for loop usage in `parsemembers.js` Removed unnecessary variables from `loadBotAfk()` and `saveBotAfk()` in `afkcheck.js` Added an emoji to the quotas panel Disabled o3parse type for shatters and osanc
Contributor
Author
|
Updated PR based on feedback |
Ragviswa
reviewed
Jan 26, 2024
Contributor
Ragviswa
left a comment
Ragviswa
left a comment
There was a problem hiding this comment.
Looks good to me now, thanks for the changes. I'm just not approving until the relevant DB changes go through. I'll do them later today if no one else gets to it.
Accepted review changes
Removed vcOptions from `saveBotAFK()` `afkChecks.js`, added it as get function instead Made `afkTitle()` and `raidLeaderName()` public helper functions in `afkChecks.js` Changed all uses of `bot.afkChecks` to `bot.afkModules` in `parsemembers.js` Fixed incorrect access functions in `vcCrasherParse()`
updated vibot version to 8.8.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ViBot [8.8.3]
Changelog
Changes
parsemembersworks with vc-less runsBugs
Examples
VC-less parsing:
Quota Values:
