Conversation
ghost
self-requested a review
as a 
4 tasks
Contributor
|
LGTM |
Removed deprecated references to raid.reactables
Made code shorter by one line to make Sauron feel a little tingle in his left nut
- Added `isVcless` to `AfkCheck` - When deciding which raid to parse, replaced the many references to bot.afkModules with a filtered list - removed `raidMembers` in favor of using `raid.members` directly - Replaced reassembleAndCheckNames with @Huntifer-RotMG 's suggestion. This has not been rigorously tested but I don't see why it shouldn't work - Removed unused `filterNames` function
Huntifer-RotMG
approved these changes
Feb 3, 2024
- Moved selecting raid into its own function - Changed isVcless to a function instead of a getter - Utilizing Array.filter for finalized crasher/alt/etc lists - Removed unnecessary null-coalesce &
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ViBot
Changelog
Changes
vcCrashersParseandnoVcCrashersParseintorunParseBugs