-
Notifications
You must be signed in to change notification settings - Fork 0
add ::testing #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add ::testing #72
Conversation
|
@laggycomputer -- there are several things to note here:
|
| use crate::MultiSiteCounts; | ||
|
|
||
| #[test] | ||
| fn watterson_theta() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is moot given the two below and can be deleted.
| // once we have a naive implementation in place | ||
| // and can test using our random data API. | ||
| #[test] | ||
| fn tajima_d() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test will be replaced by comparisons to naive impls but should be left for now.
| use std::iter::repeat_n; | ||
|
|
||
| #[test] | ||
| fn load_raw() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably come up with a version of this that uses our testdata mod, but that would be a later PR.
|
Took a look at the commented out pi test(s), figured we want to remove that quickly. We can proceed with deleting that. |
@laggycomputer -- you mean the one in test.rs? If so, that should be removed. The intent is to remove commented out code unless you have an objection at this point. We can actually delete all of test.rs. |
Move code into a testing module that is hopefully nicely-organized.