Fix unity_test_summary ruby script with parameterized tests#553
Closed
jannisbaudisch wants to merge 2 commits intoThrowTheSwitch:masterfrom
Closed
Fix unity_test_summary ruby script with parameterized tests#553jannisbaudisch wants to merge 2 commits intoThrowTheSwitch:masterfrom
jannisbaudisch wants to merge 2 commits intoThrowTheSwitch:masterfrom
Conversation
added 2 commits
April 7, 2021 13:13
When you passed a string with a colon (":") to a test via test
parameterization, the unity_test_summary.rb script was no longer
able to handle its output.
EXAMPLE:
```
TEST_CASE("::1")
void test_some_parameterized_ipv6_address(const char *address)
{
TEST_FAIL();
}
```
The reason for this is, that a simple split at colon command was used.
Changed this to a more complex regex.
PLEASE NOTE: I have no clue, how to write clean ruby code. I bet this
can be written much prettier. Feel free to change it, but at least the
concept is working.
Member
|
Merge into PR #656 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you passed a string with a colon (":") to a test via test
parameterization, the unity_test_summary.rb script was no longer
able to handle its output.
EXAMPLE:
The reason for this is, that a simple split at colon command was used.
Changed this to a more complex regex.
PLEASE NOTE: I have no clue, how to write clean ruby code. I bet this
can be written much prettier. Feel free to change it, but at least the
concept is working.