Conversation
… (classification problem)
… run 2. The position of legend changed
motiwari
requested changes
Jul 27, 2022
Contributor
motiwari
left a comment
There was a problem hiding this comment.
Overall ok but needs some fixes:
-
With vectorization off, do we now get similar numbers to those presented in the original paper?
-
Add a global
USE_VECTORIZATION = Falseinconstants.pyand use it everywhere instead of default inline values throughout
2. Add a comment on why converting the type of "n" to an array from integer.
94555e4 to
3fa2685
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete three tasks assigned by Mo here
vectorizationflag to be true/false, you can turn on and off vectorization of impurity calculations and histogram insertions (classification only as we vectorized regression case before submission)investigate_scaling.pyandmake_scaling_plot.pyon my laptop.get_impurity_reductionsfunction.\logsdirectory.