Skip to content

Three tasks for rebuttal#218

Merged
vxbrandon merged 8 commits intomainfrom
Jaeyong_tasks_rebuttal
Jul 28, 2022
Merged

Three tasks for rebuttal#218
vxbrandon merged 8 commits intomainfrom
Jaeyong_tasks_rebuttal

Conversation

@vxbrandon
Copy link
Copy Markdown
Contributor

@vxbrandon vxbrandon commented Jul 27, 2022

Complete three tasks assigned by Mo here

  • Add a boolean flag to turn on/off vectorization: Now by setting the vectorization flag to be true/false, you can turn on and off vectorization of impurity calculations and histogram insertions (classification only as we vectorized regression case before submission)
  • Change the y axis of scaling experiments from wall-clock time to the number of insertions: After this change, we can observe that our algorithm is scaling with a logarithm of data size. Images below are the graphs I plot by running investigate_scaling.py and make_scaling_plot.py on my laptop.

image (1)
image

  • Turn off the divide-by-zero warning: turn off in the first line of the get_impurity_reductions function.
  • Move all the log files to \logs directory.

@vxbrandon vxbrandon requested a review from motiwari July 27, 2022 16:37
Copy link
Copy Markdown
Contributor

@motiwari motiwari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall ok but needs some fixes:

  • With vectorization off, do we now get similar numbers to those presented in the original paper?

  • Add a global USE_VECTORIZATION = False in constants.py and use it everywhere instead of default inline values throughout

Comment thread data_structures/forest_base.py Outdated
Comment thread data_structures/forest_classifier.py Outdated
Comment thread data_structures/forest_regressor.py Outdated
Comment thread data_structures/histogram.py Outdated
Comment thread data_structures/histogram.py
Comment thread utils/criteria.py Outdated
Comment thread utils/solvers.py Outdated
Comment thread utils/solvers.py Outdated
Comment thread utils/solvers.py Outdated
Comment thread utils/utils.py Outdated
2. Add a comment on why converting the type of "n" to an array from integer.
@vxbrandon vxbrandon force-pushed the Jaeyong_tasks_rebuttal branch from 94555e4 to 3fa2685 Compare July 28, 2022 00:30
@vxbrandon vxbrandon merged commit 49a5991 into main Jul 28, 2022
@vxbrandon vxbrandon deleted the Jaeyong_tasks_rebuttal branch July 28, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants