Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an XSD schema validator for Cross Domain Acknowledgement and Response XML documents. The implementation validates XML against a UN/CEFACT XSD schema and provides detailed error reporting.
Changes:
- Added a new SchemaValidator component with interface, implementation, and result/error classes
- Created test coverage for both valid and invalid XML validation scenarios
- Removed a French comment from an existing serializer test
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/SchemaValidator/SchemaValidator.php | Core validator implementation with XML parsing and schema validation logic |
| src/SchemaValidator/SchemaValidatorInterface.php | Interface defining the validation contract |
| src/SchemaValidator/SchemaValidationResult.php | Result object containing validation status and errors |
| src/SchemaValidator/SchemaValidationError.php | Error object representing individual validation errors |
| tests/SchemaValidator/SchemaValidatorTest.php | Test cases for valid and invalid XML validation |
| tests/data/invalid_cdar.xml | Test fixture containing intentionally invalid XML |
| tests/Serializer/SerializerTest.php | Removed French comment from existing test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
samueld-pdp
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XSD Schema Validator