move away from deprecated methods step1#356
Merged
DimitrisStaratzis merged 1 commit intomasterfrom Apr 25, 2024
Merged
Conversation
teo-tsirpanis
approved these changes
Apr 24, 2024
| * @return the URI of the member with the given name | ||
| * @throws TileDBError | ||
| */ | ||
| public String getMemberByName(String name) throws TileDBError { |
Member
There was a problem hiding this comment.
You can update the v2 methods to call the new ones to reduce duplication.
Contributor
Author
There was a problem hiding this comment.
They are going to be removed very soon but yeah good catch. getFragmentNameV2() has a different return type which I can not create so I am leaving it as is.
DimitrisStaratzis
force-pushed
the
dstara/move_away_from_deprecated_methods
branch
from
9ff0d89 to
e4259d8
Compare
KiterLuc
approved these changes
Apr 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods have a
v2equivalent in the c api.When the v2 was introduced I wrapped them with the v2 in the signature. Example:
getMemberByNameV2()This is a bit ugly so I am now deprecating the versions with the v2 in the signature in favor of the old signatures. The methods with the old signatures are now using the v2 c_apis
tiledb_array_delete_fragments()is a different case. It is now deprecated and replaced by a static method.This PR removed the dependency to deprecated methods completely without introducing any breaking changes. Let me know if you want to also remove the deprecated methods completely.
[sc-45973]